From: Joel Becker <Joel.Becker@oracle.com>
To: David Teigland <teigland@redhat.com>,
akpm@osdl.org, linux-kernel@vger.kernel.org,
mark.fasheh@oracle.com
Subject: Re: [PATCH] configfs: export config_group_find_obj
Date: Fri, 19 Aug 2005 08:09:35 -0700 [thread overview]
Message-ID: <20050819150935.GD18991@ca-server1.us.oracle.com> (raw)
In-Reply-To: <20050818212022.GE22742@insight>
On Thu, Aug 18, 2005 at 02:20:23PM -0700, Joel Becker wrote:
> On Thu, Aug 18, 2005 at 02:17:49PM -0700, Joel Becker wrote:
> > On Thu, Aug 18, 2005 at 02:26:02PM +0800, David Teigland wrote:
> > > In the dlm I use config_group_find_obj() which isn't exported.
> >
> > Did you notice the /* XXX Locking */? Let me go see how you use
> > it, if it is the best way, we'll need to revisit the function and be
> > sure it's happy.
>
> Yeah, your usage is unsafe, but the fault lies with find_obj().
> Needs fixing.
And you copied the same issue into get_comm(). When navigating
cg_children (or any part of the object tree), you need to be holding the
subsystem semaphore. Someone could race with mkdir/rmdir.
Joel
--
"Senator let's be sincere,
As much as you can."
http://www.jlbec.org/
jlbec@evilplan.org
prev parent reply other threads:[~2005-08-19 15:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-18 6:26 [PATCH] configfs: export config_group_find_obj David Teigland
2005-08-19 15:09 ` Joel Becker
[not found] ` <20050818211749.GD22742@insight>
2005-08-19 15:09 ` Joel Becker
[not found] ` <20050818212022.GE22742@insight>
2005-08-19 15:09 ` Joel Becker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050819150935.GD18991@ca-server1.us.oracle.com \
--to=joel.becker@oracle.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.fasheh@oracle.com \
--cc=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.