From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Grundler Subject: Re: [parisc-linux] [PATCH] Support for AD1889 PCI Soundchip Date: Fri, 19 Aug 2005 19:36:55 -0600 Message-ID: <20050820013655.GC6376@colo.lackof.org> References: <20050817101017.008D03658E8@mail.esiee.fr> <20050819174655.GA6376@colo.lackof.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: alsa-devel-admin@lists.sourceforge.net Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Takashi Iwai Cc: Clemens Ladisch , Thibaut VARENE , alsa-devel@lists.sourceforge.net, parisc-linux@lists.parisc-linux.org, kyle@parisc-linux.org List-Id: alsa-devel@alsa-project.org On Fri, Aug 19, 2005 at 07:53:22PM +0200, Takashi Iwai wrote: > Check his patch carefully. It doesn't add any extra accesses (except > for one readl to flush in irq handler - I guess it was added to be > sure?). The original driver didn't use these fields effectively at > all, too. Sorry - I didn't look at patch at all. If the fields were never used, removing them is fine. If they *could* have been used, then removing them is a bad idea. In general, referencing parameters in IO device registers is NOT a good substitute for caching the values "locally" in host mem. hth, grant ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf