From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1E6Sgu-0004hj-77 for mharc-grub-devel@gnu.org; Sat, 20 Aug 2005 08:43:16 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1E6Sgm-0004dG-4g for grub-devel@gnu.org; Sat, 20 Aug 2005 08:43:09 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1E6Sgc-0004Wq-6C for grub-devel@gnu.org; Sat, 20 Aug 2005 08:43:00 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1E6Sga-0004Tk-TP for grub-devel@gnu.org; Sat, 20 Aug 2005 08:42:57 -0400 Received: from [212.43.237.68] (helo=kotoba.storever.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1E6ScA-0004ue-OD for grub-devel@gnu.org; Sat, 20 Aug 2005 08:38:22 -0400 Received: from ASSP-nospam (localhost [127.0.0.1]) by kotoba.storever.com (Postfix) with ESMTP id ED50EFFC1FE0 for ; Sat, 20 Aug 2005 14:38:13 +0200 (CEST) Received: from 127.0.0.1 ([127.0.0.1] helo=ip6-localhost) by ASSP-nospam ; 20 Aug 05 12:38:13 -0000 From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Sat, 20 Aug 2005 14:36:51 +0200 User-Agent: KMail/1.7.2 References: <430716B7.1000806@yahoo.fr> In-Reply-To: <430716B7.1000806@yahoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200508201436.51320.okuji@enbug.org> Subject: Re: sparc64 port X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Aug 2005 12:43:13 -0000 On Saturday 20 August 2005 13:40, Vincent Pelletier wrote: > * boot/sparc64/ieee1275/cmain.c: New file. This is wrong. I guess you just followed the powerpc port, but it is also=20 wrong. Instead, this file must be put in the kernel. The directory boot is= =20 used to organize files for the bootstrap of the kernel, which are not a par= t=20 of the kernel. In principle, the kernel should not be linked with a file in another=20 directory. Unfortunately, this is not always true, in order to solve "chick= en=20 and egg" problems. Nevertheless, we should try to make the kernel as much=20 independent of other directories as possible. >=A0=A0=A0=A0=A0=A0=A0* kern/sparc64/cache.c: New file. The contents of this file is strange. Why don't you simply include=20 grub/cache.h? About the ChangeLog: Please do not mention new directories. They are not worth describing, becau= se=20 they don't cause bugs, and they are not related to copyright problems. Please use simply "Likewise" when you repeat the same description. This is = not=20 obligatory, but often easier to read. Okuji