From: Dave Jones <davej@redhat.com>
To: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
Cc: Linus Torvalds <torvalds@g5.osdl.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
g@parcelfarce.linux.theplanet.co.uk
Subject: Re: Fix up befs compile.
Date: Sat, 20 Aug 2005 16:35:38 -0400 [thread overview]
Message-ID: <20050820203538.GA19728@redhat.com> (raw)
In-Reply-To: <20050820195807.GD29811@parcelfarce.linux.theplanet.co.uk>
On Sat, Aug 20, 2005 at 08:58:07PM +0100, Al Viro wrote:
> On Sat, Aug 20, 2005 at 03:48:40PM -0400, Dave Jones wrote:
> > fs/befs/linuxvfs.c:466: error: conflicting types for 'befs_follow_link'
> > fs/befs/linuxvfs.c:44: error: previous declaration of 'befs_follow_link' was here
> > fs/befs/linuxvfs.c: In function 'befs_follow_link':
> > fs/befs/linuxvfs.c:490: warning: return makes integer from pointer without a cast
>
> It should be void *, not void.
Duh. Yes. of course.
Signed-off-by: Dave Jones <davej@redhat.com>
--- linux-2.6.12/fs/befs/linuxvfs.c~ 2005-08-20 15:46:30.000000000 -0400
+++ linux-2.6.12/fs/befs/linuxvfs.c 2005-08-20 15:47:25.000000000 -0400
@@ -461,7 +461,7 @@ befs_destroy_inodecache(void)
* The data stream become link name. Unless the LONG_SYMLINK
* flag is set.
*/
-static int
+static void *
befs_follow_link(struct dentry *dentry, struct nameidata *nd)
{
befs_inode_info *befs_ino = BEFS_I(dentry->d_inode);
Dave
prev parent reply other threads:[~2005-08-20 20:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-20 19:48 Fix up befs compile Dave Jones
2005-08-20 19:58 ` Al Viro
2005-08-20 20:35 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050820203538.GA19728@redhat.com \
--to=davej@redhat.com \
--cc=g@parcelfarce.linux.theplanet.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@g5.osdl.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.