From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1E7x03-0006vt-Fr for qemu-devel@nongnu.org; Wed, 24 Aug 2005 11:17:11 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1E7x01-0006vS-F9 for qemu-devel@nongnu.org; Wed, 24 Aug 2005 11:17:11 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1E7wsw-0004mZ-JY for qemu-devel@nongnu.org; Wed, 24 Aug 2005 11:09:50 -0400 Received: from [65.74.133.11] (helo=mail.codesourcery.com) by monty-python.gnu.org with esmtp (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA:24) (Exim 4.34) id 1E7wZz-0006bc-23 for qemu-devel@nongnu.org; Wed, 24 Aug 2005 10:50:15 -0400 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH] const / static (against current CVS) Date: Wed, 24 Aug 2005 15:49:04 +0100 References: <20050823174026.GA27203@rhlx01.fht-esslingen.de> <200508241441.45656.paul@codesourcery.com> <20050824143851.GA24595@rhlx01.fht-esslingen.de> In-Reply-To: <20050824143851.GA24595@rhlx01.fht-esslingen.de> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200508241549.04816.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Wednesday 24 August 2005 15:38, Andreas Mohr wrote: > Hi, > > On Wed, Aug 24, 2005 at 02:41:44PM +0100, Paul Brook wrote: > > > Probably more important is to make sure none constant data structures > > > are done on the stack. There is no good reason why any code page > > > should be read-write. > > > > Huh? this is nonsense. > > Uhoh, I seem to have managed to stir up a veritable hornet's net with my > patch... For the record this wasn't intended as a criticism of your patch. I think adding const/static is a good idea for debugging/maintainability, even if it doesn't give any actual performance benefits. Paul