All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@osdl.org>
To: Zachary Amsden <zach@vmware.com>
Cc: Chris Wright <chrisw@osdl.org>, Andrew Morton <akpm@osdl.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Virtualization Mailing List <virtualization@lists.osdl.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Zwane Mwaikambo <zwane@arm.linux.org.uk>,
	Martin Bligh <mbligh@mbligh.org>,
	Pratap Subrahmanyam <pratap@vmware.com>,
	Christopher Li <chrisl@vmware.com>
Subject: Re: [UPDATED] Re: [PATCH 1/5] Add pagetable allocation notifiers
Date: Wed, 24 Aug 2005 15:01:46 -0700	[thread overview]
Message-ID: <20050824220146.GR7762@shell0.pdx.osdl.net> (raw)
In-Reply-To: <430CE9F2.4070605@vmware.com>

* Zachary Amsden (zach@vmware.com) wrote:
> Done.  Looks like you want empty_zero_page write protected too.  That 
> seems like a fine idea to me unless something really wants to do atomic 
> 64-bit reads on it.

Thanks, I added this set (minus the 3/5, which I already have) to the
virt-2.6 tree.

> The -1 is quite useless when you're going to shift  >> 12 anyways to get 
> a frame number to index into mem_map, which is why they are not there.  
> Plus, it just seems scary if you got it wrong - let's say you had a not 
> present page - not that you could, but now you are freeing a misaligned 
> address in the _previous_ page.  I really don't like that -1 at all.  I 
> will clean it up, but it does certainly deserve another patch.

Heh, that's exactly what I was concerned with from the patch (being on
the wrong page).  Thanks for clearing up my confusion.



  reply	other threads:[~2005-08-24 22:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-24 18:41 [PATCH 1/5] Add pagetable allocation notifiers Zachary Amsden
2005-08-24 19:48 ` Chris Wright
2005-08-24 21:13   ` Zachary Amsden
2005-08-24 21:18     ` Chris Wright
2005-08-24 21:43       ` [UPDATED] " Zachary Amsden
2005-08-24 22:01         ` Chris Wright [this message]
2005-08-24 21:47   ` Zachary Amsden
2005-08-24 22:00     ` Chris Wright

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050824220146.GR7762@shell0.pdx.osdl.net \
    --to=chrisw@osdl.org \
    --cc=akpm@osdl.org \
    --cc=chrisl@vmware.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mbligh@mbligh.org \
    --cc=pratap@vmware.com \
    --cc=virtualization@lists.osdl.org \
    --cc=zach@vmware.com \
    --cc=zwane@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.