From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964901AbVHYJX1 (ORCPT ); Thu, 25 Aug 2005 05:23:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964902AbVHYJX1 (ORCPT ); Thu, 25 Aug 2005 05:23:27 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:62374 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S964901AbVHYJX0 (ORCPT ); Thu, 25 Aug 2005 05:23:26 -0400 Date: Thu, 25 Aug 2005 10:23:23 +0100 From: Christoph Hellwig To: Eric Dumazet Cc: Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] removes filp_count_lock and changes nr_files type to atomic_t Message-ID: <20050825092322.GA9902@infradead.org> Mail-Followup-To: Christoph Hellwig , Eric Dumazet , Andrew Morton , linux-kernel@vger.kernel.org References: <20050824214610.GA3675@localhost.localdomain> <1124956563.3222.8.camel@laptopd505.fenrus.org> <430D8518.8020502@cosmosbay.com> <20050825090854.GA9740@infradead.org> <430D8CA3.3030709@cosmosbay.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <430D8CA3.3030709@cosmosbay.com> User-Agent: Mutt/1.4.2.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 25, 2005 at 11:17:23AM +0200, Eric Dumazet wrote: > >But that's not true. You need to write you own sysctl handler for it, > >probably worth adding a generic atomic_t sysctl handler while you're > >at it. > > > > I checked linux-2.6.13-rc7 tree, and atomic_read() is just a wrapper to > read v->counter. That doesn't matter. atomic_t is an opaqueue type and you must use the atomic_* interfaces to access it.