All of lore.kernel.org
 help / color / mirror / Atom feed
From: khali@linux-fr.org (Jean Delvare)
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Greg Kroah-Hartman <greg@kroah.com>,
	torvalds@osdl.org, akpm@osdl.org, linux-kernel@vger.kernel.org,
	lm-sensors@lm-sensors.org, Jonathan Corbet <corbet@lwn.net>
Subject: [lm-sensors] Re: [PATCH] drivers/hwmon/*: kfree() correct pointers
Date: Fri, 26 Aug 2005 00:03:11 +0000	[thread overview]
Message-ID: <20050826000231.35b97af9.khali@linux-fr.org> (raw)
In-Reply-To: <20050825214913.GA31605@mipter.zuzino.mipt.ru>

Hi Alexey,

> The adm9240 driver, in adm9240_detect(), allocates a structure.  The
> error path attempts to kfree() ->client field of it (second one),
> resulting in an oops (or slab corruption) if the hardware is not
> present.
> 
> ->client field in adm1026, adm1031, smsc47b397 and smsc47m1 is the
> first in ${HWMON}_data structure, but fix them too.

Already fixed in Greg's i2c tree and -mm for quite some time now...

http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/gregkh-02-i2c/i2c-hwmon-class-01.patch

Thanks,
-- 
Jean Delvare

WARNING: multiple messages have this Message-ID (diff)
From: Jean Delvare <khali@linux-fr.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Greg Kroah-Hartman <greg@kroah.com>,
	torvalds@osdl.org, akpm@osdl.org, linux-kernel@vger.kernel.org,
	lm-sensors@lm-sensors.org, Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH] drivers/hwmon/*: kfree() correct pointers
Date: Fri, 26 Aug 2005 00:02:31 +0200	[thread overview]
Message-ID: <20050826000231.35b97af9.khali@linux-fr.org> (raw)
In-Reply-To: <20050825214913.GA31605@mipter.zuzino.mipt.ru>

Hi Alexey,

> The adm9240 driver, in adm9240_detect(), allocates a structure.  The
> error path attempts to kfree() ->client field of it (second one),
> resulting in an oops (or slab corruption) if the hardware is not
> present.
> 
> ->client field in adm1026, adm1031, smsc47b397 and smsc47m1 is the
> first in ${HWMON}_data structure, but fix them too.

Already fixed in Greg's i2c tree and -mm for quite some time now...

http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/gregkh-02-i2c/i2c-hwmon-class-01.patch

Thanks,
-- 
Jean Delvare

  reply	other threads:[~2005-08-26  0:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-25 20:56 [PATCH] fix adm9240 oops Jonathan Corbet
2005-08-25 21:49 ` [PATCH] drivers/hwmon/*: kfree() correct pointers Alexey Dobriyan
2005-08-25 23:41   ` [lm-sensors] " Alexey Dobriyan
2005-08-25 22:02   ` Jean Delvare [this message]
2005-08-26  0:03     ` [lm-sensors] " Jean Delvare
2005-08-25 23:53     ` Jonathan Corbet
2005-08-26  1:54       ` [lm-sensors] " Jonathan Corbet
2005-08-26  7:32       ` Jean Delvare
2005-08-26  9:32         ` [lm-sensors] " Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050826000231.35b97af9.khali@linux-fr.org \
    --to=khali@linux-fr.org \
    --cc=adobriyan@gmail.com \
    --cc=akpm@osdl.org \
    --cc=corbet@lwn.net \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.