From: Dave Jones <davej@redhat.com>
To: Robert Love <rml@novell.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Arjan van de Ven <arjan@infradead.org>,
Brian Gerst <bgerst@didntduck.org>, Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [patch] IBM HDAPS accelerometer driver.
Date: Fri, 26 Aug 2005 16:27:33 -0400 [thread overview]
Message-ID: <20050826202733.GA26003@redhat.com> (raw)
In-Reply-To: <1125084555.18155.89.camel@betsy>
On Fri, Aug 26, 2005 at 03:29:15PM -0400, Robert Love wrote:
> On Fri, 2005-08-26 at 20:55 +0100, Alan Cox wrote:
>
> > I think that should be fixed before its merged.
>
> Let me be clear, it has an init routine that effectively probes for the
> device.
>
> It just lacks a simple quick non-invasive check.
>
> The driver will definitely fail to load on a laptop without the
> requisite hardware.
Poking IO ports on hardware where you don't have the device
can be fatal. What happens if I have something completely different
at io port 0x1600 ? (Thus satisfying your request_region() check).
accelerometer_init() then happily starts poking ports, and performing
all kinds of voodoo.
Dave
next prev parent reply other threads:[~2005-08-26 20:28 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-26 15:18 [patch] IBM HDAPS accelerometer driver Robert Love
2005-08-26 17:05 ` Bill Nottingham
2005-08-26 17:15 ` Robert Love
2005-08-26 17:33 ` Brian Gerst
2005-08-26 17:33 ` Robert Love
2005-08-26 18:01 ` Arjan van de Ven
2005-08-26 18:03 ` Robert Love
2005-08-26 18:45 ` Dave Jones
2005-08-26 18:52 ` Robert Love
2005-08-26 19:55 ` Alan Cox
2005-08-26 19:29 ` Robert Love
2005-08-26 19:33 ` Jeff Garzik
2005-08-26 19:37 ` Robert Love
2005-08-26 20:21 ` Alan Cox
2005-08-26 22:43 ` Andi Kleen
2005-08-26 20:27 ` Dave Jones [this message]
2005-08-26 19:54 ` Alan Cox
2005-08-26 18:18 ` Andrew Morton
2005-08-26 18:30 ` Robert Love
2005-08-26 19:27 ` Dmitry Torokhov
2005-08-26 19:39 ` Robert Love
2005-08-26 19:43 ` Robert Love
2005-08-26 20:09 ` Dmitry Torokhov
2005-08-26 20:12 ` Dmitry Torokhov
2005-08-28 11:00 ` Yani Ioannou
2005-08-27 12:41 ` Pavel Machek
2005-08-28 2:59 ` Mikulas Patocka
2005-08-28 8:09 ` Pavel Machek
2005-08-28 9:21 ` Oliver Neukum
2005-08-28 19:30 ` Mikulas Patocka
2005-08-29 8:35 ` Pavel Machek
2005-08-29 8:59 ` Oliver Neukum
2005-08-29 9:10 ` Pavel Machek
2005-08-30 17:44 ` Mikulas Patocka
2005-08-31 0:12 ` Yani Ioannou
[not found] <4FOa3-8fm-39@gated-at.bofh.it>
[not found] ` <4GlyV-3Rk-3@gated-at.bofh.it>
[not found] ` <4GqyE-2bk-19@gated-at.bofh.it>
[not found] ` <4GrEp-3E2-21@gated-at.bofh.it>
2005-08-28 16:26 ` Robert Hancock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050826202733.GA26003@redhat.com \
--to=davej@redhat.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arjan@infradead.org \
--cc=bgerst@didntduck.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rml@novell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.