From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1E9N5h-0006Lm-U5 for mharc-grub-devel@gnu.org; Sun, 28 Aug 2005 09:20:54 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1E9N5f-0006JI-Ep for grub-devel@gnu.org; Sun, 28 Aug 2005 09:20:51 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1E9N5d-0006Gv-J2 for grub-devel@gnu.org; Sun, 28 Aug 2005 09:20:50 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1E9N1I-0004Ub-HR for grub-devel@gnu.org; Sun, 28 Aug 2005 09:16:20 -0400 Received: from [212.43.237.68] (helo=kotoba.storever.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1E9MeS-0006eB-TB for grub-devel@gnu.org; Sun, 28 Aug 2005 08:52:45 -0400 Received: from ASSP-nospam (localhost [127.0.0.1]) by kotoba.storever.com (Postfix) with ESMTP id D75ECFF94DA0 for ; Sun, 28 Aug 2005 14:50:43 +0200 (CEST) Received: from 127.0.0.1 ([127.0.0.1] helo=ip6-localhost) by ASSP-nospam ; 28 Aug 05 12:50:43 -0000 From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Sun, 28 Aug 2005 14:49:34 +0200 User-Agent: KMail/1.7.2 References: <430A4263.1020103@inma.ucl.ac.be> In-Reply-To: <430A4263.1020103@inma.ucl.ac.be> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200508281449.34476.okuji@enbug.org> Subject: Re: backtrace support X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Aug 2005 13:20:52 -0000 On Monday 22 August 2005 23:23, Vincent Guffens wrote: > +# For kern_debug.mod > +kern_debug_mod_OTHERDEP =3D kern/grub_debug_kern.sym > +kern_debug_mod_SOURCES =3D kern/kern_debug.c > +kern_debug_mod_CFLAGS =3D $(COMMON_CFLAGS)=20 I think it is a really good idea to make a variable for dependencies, but I= =20 would suggest a different name for this. Can this be just=20 kern_debug_mod_DEPENDENCIES? > +# take care of the configure arguments > + > +AC_ARG_WITH(debug, [ =C2=A0--with-debug =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0enable some debug=20 mechanisms]) I think it would be better to use AC_ARG_ENABLE with --enable-debug, becaus= e=20 =2D-with is used to specify external programs in autoconf. > diff -ru -N -b -B grub2/gendebugkern.sh grub2-backtrace/gendebugkern.sh > --- grub2/gendebugkern.sh=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A01970-0= 1-01 01:00:00.000000000 +0100 > +++ grub2-backtrace/gendebugkern.sh=C2=A0=C2=A0=C2=A0=C2=A0=C2=A02005-08-= 22 18:47:48.000000000 +0200 > @@ -0,0 +1,14 @@ > +#!/bin/bash Please do not use /bin/bash for portability. It should be: #! /bin/sh > +void EXPORT_FUNC(grub_register_debug_sym) (const char*, void*,=20 grub_size_t); > +void EXPORT_FUNC(grub_unregister_debug_sym) (void *); > +int EXPORT_FUNC(grub_print_debug_sym) (grub_addr_t); > +void EXPORT_FUNC(grub_backtrace) (void); Why do you need to export these functions? Are they used outside the kernel? Okuji