Re: [RFH][PATCH] CS5535 driver

[Vojtech Pavlik <vojtech@suse.cz>]

On Mon, Aug 29, 2005 at 05:48:26PM +0200, Bartlomiej Zolnierkiewicz wrote:
> Hi,
> 
> Alan Cox has sent me this driver recently.  It needs a little bit of
> work to become
> acceptable into mainline kernel and as I don't have neither the hardware nor the
> time to work on it now, I'm posting it to you and linux-ide ML with a remaining
> TODO list (original patch attached to the mail). :-)
> 
> I hope that somebody will work on it so that it can be merged soon.
> 
> * cs5535_tuneproc() needs to be fixed to not abuse ->tuneproc interface
>   (which is exported to user-space), all DMA tuning should be done through
>   ->speedproc interface only
> * cs5535_set_drive() needs to use ide_rate_filter() to limit values passed
>   from the user-space
> * cs5535_set_drive() needs to set drive's speed unconditionally otherwise
>   drive may not be setup correctly after resume
> * cs5535_set_drive() shouldn't change drive->current_speed
> * cable detection needs to be in separate function (for hotplug - later)
> * driver lacks device side cable detection [ see eighty_ninty_three() ]

That, as far as I know, only works on mainboards with a capacitor
installed. If there is host cable detection, it doesn't work reliably.


-- 
Vojtech Pavlik
SuSE Labs, SuSE CR