All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jesper Juhl <jesper.juhl@gmail.com>
To: Chris Zankel <chris@zankel.net>
Cc: "linux-kernel" <linux-kernel@vger.kernel.org>
Subject: We also need to get rid of verify_area in entry.S
Date: Mon, 29 Aug 2005 19:54:26 +0200	[thread overview]
Message-ID: <200508291954.27026.jesper.juhl@gmail.com> (raw)

Hi Chris,

In addition to the patch I sent a few minutes ago, there's one last reference
to verify_area left in xtensa. It's in arch/xtensa/kernel/entry.S, and I'm 
going to need your help to get rid of that one since that code is over my head
and I assume that the naive approach below would just break it : 

diff -upr -X ./linux-2.6.13/Documentation/dontdiff linux-2.6.13-orig/arch/xtensa/kernel/entry.S linux-2.6.13/arch/xtensa/kernel/entry.S
--- linux-2.6.13-orig/arch/xtensa/kernel/entry.S	2005-08-29 01:41:01.000000000 +0200
+++ linux-2.6.13/arch/xtensa/kernel/entry.S	2005-08-29 03:48:43.000000000 +0200
@@ -1102,7 +1102,7 @@ ENTRY(fast_syscall_sysxtensa)
 	s32i	a7, a2, PT_AREG7
 
 	movi	a7, 4			# sizeof(unsigned int)
-	verify_area a3, a7, a0, a2, .Leac
+	access_ok a3, a7, a0, a2, .Leac
 
 	_beqi	a6, SYSXTENSA_ATOMIC_SET, .Lset
 	_beqi	a6, SYSXTENSA_ATOMIC_EXG_ADD, .Lexg

So, could you come up with a working patch and push it to Andrew along with the
one I sent a little while ago, so I can push my verify_area removal patches? Or
you can just sign off on my previous patch if it's OK, and send me one for 
entry.S and then I'll push the entire thing onwards if you prefer that.
Thanks in advance.


-- 
 Jesper Juhl



             reply	other threads:[~2005-08-29 17:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-29 17:54 Jesper Juhl [this message]
2005-08-29 18:21 ` We also need to get rid of verify_area in entry.S Chris Zankel
2005-08-29 19:44   ` Jesper Juhl
2006-05-07 20:56     ` Jesper Juhl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200508291954.27026.jesper.juhl@gmail.com \
    --to=jesper.juhl@gmail.com \
    --cc=chris@zankel.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.