From mboxrd@z Thu Jan  1 00:00:00 1970
From: KOVACS Krisztian <hidden@balabit.hu>
Subject: Re: [PATCH 3/3] CLUSTERIP: use a bitmap to store node
	responsibility data
Date: Tue, 30 Aug 2005 15:34:31 +0200
Message-ID: <200508301534.32353@nienna>
References: <20050830121535.985929000@nienna.balabit>
	<20050830121550.543376000@nienna.balabit>
	<43145F3B.4050706@netfilter.org>
Mime-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Cc: Harald Welte <laforge@netfilter.org>, netfilter-devel@lists.netfilter.org
Return-path: <netfilter-devel-bounces@lists.netfilter.org>
To: Pablo Neira <pablo@netfilter.org>
In-Reply-To: <43145F3B.4050706@netfilter.org>
Content-Disposition: inline
List-Unsubscribe: <https://lists.netfilter.org/mailman/listinfo/netfilter-devel>,
	<mailto:netfilter-devel-request@lists.netfilter.org?subject=unsubscribe>
List-Archive: </pipermail/netfilter-devel>
List-Post: <mailto:netfilter-devel@lists.netfilter.org>
List-Help: <mailto:netfilter-devel-request@lists.netfilter.org?subject=help>
List-Subscribe: <https://lists.netfilter.org/mailman/listinfo/netfilter-devel>,
	<mailto:netfilter-devel-request@lists.netfilter.org?subject=subscribe>
Sender: netfilter-devel-bounces@lists.netfilter.org
Errors-To: netfilter-devel-bounces@lists.netfilter.org
List-Id: netfilter-devel.vger.kernel.org


  Hi,

On Tuesday 30 August 2005 15.29, Pablo Neira wrote:
> KOVACS Krisztian wrote:
> > @@ -55,8 +56,7 @@
> >  	u_int8_t clustermac[ETH_ALEN];		/* the MAC address */
> >  	struct net_device *dev;			/* device */
> >  	u_int16_t num_total_nodes;		/* total number of nodes */
> > -	u_int16_t num_local_nodes;		/* number of local nodes */
> > -	u_int16_t local_nodes[CLUSTERIP_MAX_NODES];	/* node number array
> > */ +	unsigned long local_nodes;		/* node number array */
>
> I'm afraid that this breaks backward compatibility. Although
> CLUSTERIP is marked as experimental.

  IMHO this does not break compatibility, since this change only affects 
the internal clusterip_config structure, not the target info structure 
itself. (And the module does conversion in checkentry().)

-- 
 Regards,
  Krisztian Kovacs