All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Michael Krufky <mkrufky@m1k.net>
Cc: stable@kernel.org, Andrew Morton <akpm@osdl.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Mauro Carvalho Chehab <mchehab@brturbo.com.br>,
	linux-dvb-maintainer@linuxtv.org, torvalds@osdl.org
Subject: [2.6 patch] add missing select's to DVB_BUDGET_AV
Date: Wed, 31 Aug 2005 17:43:51 +0200	[thread overview]
Message-ID: <20050831154350.GB8638@stusta.de> (raw)
In-Reply-To: <4314B7C2.2080705@m1k.net>

On Tue, Aug 30, 2005 at 03:47:14PM -0400, Michael Krufky wrote:

> I wish I had seen this before 2.6.13 was released... I guess this only 
> goes to show that there haven't been any testers using saa7134-hybrid 
> dvb/v4l boards that depend on the tda1004x module, during the 2.6.13-rc 
> series :-(
> 
> Please apply this to 2.6.14, and also to 2.6.13.1 -stable.  Without this 
> patch, users will have to EXPLICITLY select tda1004x in Kconfig.  This 
> SHOULD be done automatically when saa7134-dvb is selected.  This patch 
> corrects this problem.
>...

What about the patch below fixing the following similar problems in 
drivers/media/dvb/ttpci/budget-ci.c ?

cu
Adrian


<--  snip  -->



Add missing select's to DVB_BUDGET_AV fixing the following compile 
error:

<--  snip  -->

...
  LD      .tmp_vmlinux1
drivers/built-in.o: In function `frontend_init':
budget-av.c:(.text+0xb9448): undefined reference to `tda10046_attach'
budget-av.c:(.text+0xb9518): undefined reference to `tda10021_attach'
drivers/built-in.o: In function `philips_tu1216_request_firmware':
budget-av.c:(.text+0xb937b): undefined reference to `request_firmware'
make: *** [.tmp_vmlinux1] Error 1

<--  snip  -->


Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.13/drivers/media/dvb/ttpci/Kconfig.old	2005-08-31 17:36:33.000000000 +0200
+++ linux-2.6.13/drivers/media/dvb/ttpci/Kconfig	2005-08-31 17:39:57.000000000 +0200
@@ -99,12 +99,15 @@
 config DVB_BUDGET_AV
 	tristate "Budget cards with analog video inputs"
 	depends on DVB_CORE && PCI
 	select VIDEO_DEV
 	select VIDEO_SAA7146_VV
 	select DVB_STV0299
+	select DVB_TDA1004X
+	select DVB_TDA10021
+	select FW_LOADER
 	help
 	  Support for simple SAA7146 based DVB cards
 	  (so called Budget- or Nova-PCI cards) without onboard
 	  MPEG2 decoder, but with one or more analog video inputs.
 
 	  Say Y if you own such a card and want to use it.


  reply	other threads:[~2005-08-31 15:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-30 19:47 [PATCH] Kconfig: saa7134-dvb must select tda1004x Michael Krufky
2005-08-31 15:43 ` Adrian Bunk [this message]
2005-08-31 16:59   ` [linux-dvb-maintainer] [2.6 patch] add missing select's to DVB_BUDGET_AV Johannes Stezenbach
2005-08-31 17:09     ` Adrian Bunk
2005-08-31 18:55       ` Michael Krufky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050831154350.GB8638@stusta.de \
    --to=bunk@stusta.de \
    --cc=akpm@osdl.org \
    --cc=linux-dvb-maintainer@linuxtv.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@brturbo.com.br \
    --cc=mkrufky@m1k.net \
    --cc=stable@kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.