From: Jens Axboe <axboe@suse.de>
To: Brian King <brking@us.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] block: CFQ refcounting fix
Date: Wed, 31 Aug 2005 17:50:24 +0200 [thread overview]
Message-ID: <20050831155023.GE4018@suse.de> (raw)
In-Reply-To: <4315B74D.8020100@us.ibm.com>
On Wed, Aug 31 2005, Brian King wrote:
> diff -puN drivers/block/cfq-iosched.c~cfq_refcnt_fix drivers/block/cfq-iosched.c
> --- linux-2.6/drivers/block/cfq-iosched.c~cfq_refcnt_fix 2005-08-30 17:26:55.000000000 -0500
> +++ linux-2.6-bjking1/drivers/block/cfq-iosched.c 2005-08-31 08:48:30.000000000 -0500
> @@ -2260,8 +2260,6 @@ static void cfq_put_cfqd(struct cfq_data
> if (!atomic_dec_and_test(&cfqd->ref))
> return;
>
> - blk_put_queue(q);
> -
> cfq_shutdown_timer_wq(cfqd);
> q->elevator->elevator_data = NULL;
>
> @@ -2318,7 +2316,6 @@ static int cfq_init_queue(request_queue_
> e->elevator_data = cfqd;
>
> cfqd->queue = q;
> - atomic_inc(&q->refcnt);
>
> cfqd->max_queued = q->nr_requests / 4;
> q->nr_batching = cfq_queued;
> _
That looks better. I'll add this to my outgoing queue, thanks!
--
Jens Axboe
prev parent reply other threads:[~2005-08-31 15:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-30 22:41 [PATCH 1/1] block: CFQ refcounting fix brking
2005-08-31 7:28 ` Jens Axboe
2005-08-31 13:40 ` Brian King
2005-08-31 13:43 ` Jens Axboe
2005-08-31 13:57 ` Brian King
2005-08-31 15:50 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050831155023.GE4018@suse.de \
--to=axboe@suse.de \
--cc=brking@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.