From: Ingo Molnar <mingo@elte.hu>
To: Rui Nuno Capela <rncbc@rncbc.org>
Cc: linux-kernel@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [patch] drivers/ide/pci/alim15x3.c SMP fix
Date: Thu, 1 Sep 2005 10:17:53 +0200 [thread overview]
Message-ID: <20050901081753.GA7952@elte.hu> (raw)
In-Reply-To: <4316B82B.2060306@rncbc.org>
* Rui Nuno Capela <rncbc@rncbc.org> wrote:
> Ingo Molnar wrote:
> >is this the right way to fix the UP assumption below?
> >
> > Ingo
> >
> >Signed-off-by: Ingo Molnar <mingo@elte.hu>
> >
> >Index: linux/drivers/ide/pci/alim15x3.c
> > [snip]
>
> OK. The reported boot WARNING seems to be over now. Tested on the
> offended laptop (P4@2.53Ghz/UP, PCI chipset: ALi M1533) with
> 2.6.13-rt3, where the suggested patch on drivers/ide/pci/alim15x3.c
> seems to fix the burp. All seems to be working fine, still ;)
just to make sure the original point gets across: the warning is only in
the -rt tree, and it pinpoints potential SMP bugs. Does your box do
hyperthreading? If yes then this could be a live (but probably mostly
harmless) SMP bug. Maybe the whole IRQ disabling is unnecessary?
__devinit is mostly serialized, so i'm not sure there's any protection
needed against parallel IRQs?
Ingo
next prev parent reply other threads:[~2005-09-01 8:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-01 7:24 [patch] drivers/ide/pci/alim15x3.c SMP fix Ingo Molnar
2005-09-01 8:13 ` Rui Nuno Capela
2005-09-01 8:17 ` Ingo Molnar [this message]
2005-09-01 8:51 ` Rui Nuno Capela
2005-09-01 10:42 ` Alan Cox
2005-10-03 6:50 ` Ingo Molnar
2005-10-03 16:24 ` Alan Cox
2005-10-04 9:29 ` tsc_c3_compensate undefined since patch-2.6.13-rt13 Rui Nuno Capela
2005-10-04 10:14 ` Ingo Molnar
2005-10-04 13:07 ` Rui Nuno Capela
2005-10-16 22:43 ` Rui Nuno Capela
2005-10-17 12:48 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050901081753.GA7952@elte.hu \
--to=mingo@elte.hu \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=rncbc@rncbc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.