From: viro@ZenIV.linux.org.uk
To: Arjan van de Ven <arjan@infradead.org>
Cc: David Teigland <teigland@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/14] GFS: headers
Date: Thu, 1 Sep 2005 15:29:37 +0100 [thread overview]
Message-ID: <20050901142937.GC26264@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1125584374.5025.18.camel@laptopd505.fenrus.org>
On Thu, Sep 01, 2005 at 04:19:34PM +0200, Arjan van de Ven wrote:
> > +/* Endian functions */
>
> ehhhh again why??
> Why is this a compiletime hack?
> Either you care about either-endian on disk, at which point it has to be
> a runtime thing, or you make the on disk layout fixed endian, at which
> point you really shouldn't abstract be16_to_cpu etc any further!
Well... I would disagree with the very end of it (e.g. having on-disk
block number representation declared as __bitwise, so that it wouldn't be
mixed with __be<n> + having coversion helpers consisting of
static inline u32 foo_to_cpu(foo n)
{
return be32_to_cpu((__force __be32)n);
}
etc. may be valid technics, assuming that these objects were passed around
enough to deserve it.
Blanket "let's rename for the sake of renaming" is a BS, of course...
next prev parent reply other threads:[~2005-09-01 14:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-01 13:54 [PATCH 01/14] GFS: headers David Teigland
2005-09-01 14:19 ` Arjan van de Ven
2005-09-01 14:29 ` viro [this message]
2005-09-01 14:59 ` David Teigland
2005-09-01 16:41 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050901142937.GC26264@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=arjan@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.