From: Christoph Hellwig <hch@infradead.org>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] altix: Add volatile qualifiers in places where it seems necessary
Date: Fri, 02 Sep 2005 15:49:53 +0000 [thread overview]
Message-ID: <20050902154953.GA7569@infradead.org> (raw)
In-Reply-To: <20050902153612.8521.73623.91869@attica.americas.sgi.com>
On Fri, Sep 02, 2005 at 10:41:52AM -0500, Mark Maule wrote:
> On Fri, Sep 02, 2005 at 04:38:09PM +0100, Christoph Hellwig wrote:
> > On Fri, Sep 02, 2005 at 10:36:12AM -0500, Mark Maule wrote:
> > > Add missing volatile qualifier to hardware MMR pointers in various SN files.
> > > Cosmetic code rearranging in pcibr_reg.c to avoid line-wraps.
> >
> > Volatile usage is wrong most of the time, and your use is certainly.
> > It seems you're accessing mmio-space or something similar and should
> > use proper acessors for it.
> >
>
> Okay. In these cases, I am indeed accessing mapped reisters. I don't know
> what you mean by "proper acessors", so a reference would be appreciated.
ioread<N> / iowrite<N>
next prev parent reply other threads:[~2005-09-02 15:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-02 15:36 [PATCH] altix: Add volatile qualifiers in places where it seems necessary Mark Maule
2005-09-02 15:38 ` Christoph Hellwig
2005-09-02 15:41 ` Mark Maule
2005-09-02 15:49 ` Christoph Hellwig [this message]
2005-09-02 15:52 ` Russ Anderson
2005-09-02 16:08 ` Mark Maule
2005-09-02 16:12 ` Christoph Hellwig
2005-09-02 18:53 ` Mark Maule
2005-09-02 19:21 ` Andreas Schwab
2005-09-02 19:57 ` Russ Anderson
2005-09-06 18:03 ` Mark Maule
2005-09-08 22:31 ` Luck, Tony
2005-09-09 20:19 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050902154953.GA7569@infradead.org \
--to=hch@infradead.org \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.