From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1EBbnY-0002gi-Gs for mharc-grub-devel@gnu.org; Sat, 03 Sep 2005 13:27:24 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EBbnX-0002fk-3k for grub-devel@gnu.org; Sat, 03 Sep 2005 13:27:23 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EBbm7-0002LR-Ip for grub-devel@gnu.org; Sat, 03 Sep 2005 13:25:59 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EBbm5-00029h-QB for grub-devel@gnu.org; Sat, 03 Sep 2005 13:25:54 -0400 Received: from [212.43.237.68] (helo=kotoba.storever.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EBbZm-00055F-7a for grub-devel@gnu.org; Sat, 03 Sep 2005 13:13:10 -0400 Received: from ASSP-nospam (localhost [127.0.0.1]) by kotoba.storever.com (Postfix) with ESMTP id C6F93FF94DA3 for ; Sat, 3 Sep 2005 19:09:42 +0200 (CEST) Received: from 127.0.0.1 ([127.0.0.1] helo=ip6-localhost) by ASSP-nospam ; 3 Sep 05 17:09:42 -0000 From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Sat, 3 Sep 2005 19:08:30 +0200 User-Agent: KMail/1.7.2 References: <4219D62D.3000109@omniflux.com> <200503022233.18661.okuji@enbug.org> <42F94D30.7030204@omniflux.com> In-Reply-To: <42F94D30.7030204@omniflux.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200509031908.30915.okuji@enbug.org> Subject: Re: x86 serial support X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Sep 2005 17:27:23 -0000 On Wednesday 10 August 2005 02:41, Omniflux wrote: > It's been a few months, but here are some updated patches. I've checked in your patch with some modification right now. I changed these below: - I removed EXPORT_FUNC from terminfo.h. EXPORT_FUNC is required only if you want to export symbols from the kernel. - I moved the inline functions in serial.h to serial.c, because they are not used outside. - I fixed bad indentation. - I removed odd const qualifiers to integers. - I fixed a memory leak in the serial command. I might have changed some other minor things as well. For now, terminfo.c has code of interpreting terminfo, but supports only vt100. Do you intend to fix this? Okuji