All of lore.kernel.org
 help / color / mirror / Atom feed
From: khali@linux-fr.org (Jean Delvare)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] Re: RFC PATCH patch-13-mm1-hwmon-adm9240-whitespace-1
Date: Sun, 04 Sep 2005 09:55:30 +0000	[thread overview]
Message-ID: <20050904095526.316d6109.khali@linux-fr.org> (raw)
In-Reply-To: <uvhkh19nggg4s7rv03ab6tetdu06jlmk42@4ax.com>

Hi Grant,

> Patches are planned to make chassis_clear write data > <dont_care>,

With what benefit?

> and rework sysfs interface to reduce driver size.

Are you referring to Yani Ioannou's dynamic sysfs callbacks? That would
be very welcome, thanks for looking into that.

> This patch removes mixed tab/space indenting,

There is nothing wrong with mixed tab/space indenting. Additionally,
this part of the code will be completely modified again if you convert
the driver to use dynamic callbacks. So I would like you not to include
these changes in this cleanup patch.

> breaks long lines,

Good.

> removed a trailing space

Good too.

Thanks,
-- 
Jean Delvare

  reply	other threads:[~2005-09-04  9:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-04  3:24 [lm-sensors] RFC PATCH patch-13-mm1-hwmon-adm9240-whitespace-1 Grant Coady
2005-09-04  9:55 ` Jean Delvare [this message]
2005-09-04 11:27 ` [lm-sensors] " Grant Coady
2005-09-04 13:29 ` Jean Delvare
2005-09-05  1:37 ` Grant Coady

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050904095526.316d6109.khali@linux-fr.org \
    --to=khali@linux-fr.org \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.