All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hiro Yoshioka <hyoshiok@miraclelinux.com>
To: akpm@osdl.org
Cc: davej@redhat.com, linux-kernel@vger.kernel.org,
	mm-commits@vger.kernel.org, hyoshiok@miraclelinux.com
Subject: Re: x86-cache-pollution-aware-__copy_from_user_ll.patch added to -mm tree
Date: Mon, 05 Sep 2005 12:19:25 +0900 (JST)	[thread overview]
Message-ID: <20050905.121925.943973397.hyoshiok@miraclelinux.com> (raw)
In-Reply-To: <20050904144218.7fe25102.akpm@osdl.org>

From: Andrew Morton <akpm@osdl.org>

> Dave Jones <davej@redhat.com> wrote:
> >
> > On Sun, Sep 04, 2005 at 01:16:00PM -0700, Andrew Morton wrote:
> >   >  unsigned long __copy_to_user_ll(void __user *to, const void *from, unsigned long n)
> >   >  {
> >   >  	BUG_ON((long) n < 0);
> > 
> >  Ehh? It's unsigned. This will never be true.
> 
> It's cast to long, so it'll trap if we try to copy >=2G.
> 
> It seems a strange thing to check though.   Do we really need it?

I don't know. I've just cut&paste the original __copy_from_user_ll()

Regards,
  Hiro

  reply	other threads:[~2005-09-05  3:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200509042017.j84KHekQ032373@shell0.pdx.osdl.net>
2005-09-04 20:23 ` x86-cache-pollution-aware-__copy_from_user_ll.patch added to -mm tree Dave Jones
2005-09-04 21:42   ` Andrew Morton
2005-09-05  3:19     ` Hiro Yoshioka [this message]
2005-09-05  4:15     ` David S. Miller
2005-09-05  4:08   ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050905.121925.943973397.hyoshiok@miraclelinux.com \
    --to=hyoshiok@miraclelinux.com \
    --cc=akpm@osdl.org \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mm-commits@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.