From: Jens Axboe <axboe@suse.de>
To: Douglas Gilbert <dougg@torque.net>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
ballen@gravity.phys.uwm.edu
Subject: Re: [PATCH] permit READ DEFECT DATA in block/scsi_ioctl
Date: Fri, 9 Sep 2005 12:25:03 +0200 [thread overview]
Message-ID: <20050909102501.GA25860@suse.de> (raw)
In-Reply-To: <43215EE4.6050003@torque.net>
On Fri, Sep 09 2005, Douglas Gilbert wrote:
> The soon to be released smartmontools 5.34 uses the
> READ DEFECT DATA command on SCSI disks. A disk that
> has defect list entries (or worse, an increasing number
> of them) is at risk.
>
> Currently the first invocation of smartctl causes this:
> scsi: unknown opcode 0x37
> message to appear the console and in the log.
>
> The READ DEFECT DATA SCSI command does not change
> the state of a disk. Its opcode (0x37) is valid for
> SBC devices (e.g. disks) and SMC-2 devices (media
> changers) where it is called INITIALIZE STATUS ELEMENT
> WITH RANGE and again doesn't change the external state
> of the device.
>
> The patch is against lk 2.6.13 .
>
> Changelog:
> - mark SCSI opcode 0x37 (READ DEFECT DATA) as
> safe_for_read
>
> Signed-off-by: Douglas Gilbert <dougg@torque.net>
Fine with me.
Acked-by: Jens Axboe <axboe@suse.de>
--
Jens Axboe
prev parent reply other threads:[~2005-09-09 10:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-09 10:07 [PATCH] permit READ DEFECT DATA in block/scsi_ioctl Douglas Gilbert
2005-09-09 10:25 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050909102501.GA25860@suse.de \
--to=axboe@suse.de \
--cc=ballen@gravity.phys.uwm.edu \
--cc=dougg@torque.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.