From: viro@ZenIV.linux.org.uk
To: Andreas Schwab <schwab@suse.de>
Cc: Linus Torvalds <torvalds@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bogus cast in bio.c
Date: Fri, 9 Sep 2005 17:36:43 +0100 [thread overview]
Message-ID: <20050909163643.GO9623@ZenIV.linux.org.uk> (raw)
In-Reply-To: <je4q8u1agp.fsf@sykes.suse.de>
On Fri, Sep 09, 2005 at 06:18:14PM +0200, Andreas Schwab wrote:
> viro@ZenIV.linux.org.uk writes:
>
> > <qualifier> void * is not the same as void <qualifier> *...
>
> IMHO it should.
... and indeed it should. My apologies - that's a combination of
sparse bug and me being very low on coffee...
FWIW, looks like we are losing address_space in the first form: with current
sparse we get
fs/bio.c:686:15: warning: incorrect type in assignment (different address spaces)
fs/bio.c:686:15: expected void [noderef] *iov_base<asn:1>
fs/bio.c:686:15: got void [noderef] *<noident>
from the first form (cast to __user void *). Lovely...
OK, I think I know what's going on there, will fix.
next prev parent reply other threads:[~2005-09-09 16:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-09 15:53 [PATCH] bogus cast in bio.c viro
2005-09-09 16:18 ` Andreas Schwab
2005-09-09 16:36 ` viro [this message]
2005-09-09 17:29 ` [sparse fix] (was Re: [PATCH] bogus cast in bio.c) viro
2005-09-09 17:34 ` viro
2005-09-09 17:48 ` Linus Torvalds
2005-09-09 18:15 ` Linus Torvalds
2005-09-09 20:10 ` viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050909163643.GO9623@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=schwab@suse.de \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.