All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Linus Torvalds <torvalds@osdl.org>,
	davej@codemonkey.org.uk, arjan@infradead.org
Cc: Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: [GIT PATCH] More PCI patches for 2.6.13
Date: Fri, 9 Sep 2005 15:54:21 -0700	[thread overview]
Message-ID: <20050909225421.GA31433@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.58.0509091535180.3051@g5.osdl.org>

On Fri, Sep 09, 2005 at 03:37:16PM -0700, Linus Torvalds wrote:
> 
> 
> On Fri, 9 Sep 2005, Greg KH wrote:
> > 
> > Dave Jones:
> >   must_check attributes for PCI layer.
> 
> Why?

This is something that David and Arjan wanted in.  Guys?

> This only clutters up the compile, hiding real errors.
> 
> I think all those compile warnings are totally bogus. Who really cares? 
> Are they going to be fixed, or were they added just to irritate people?

I fixed up all of the PCI core and USB drivers that were flagged by
these warnings already.  Biggest area left is network drivers that I
saw.

> We should have a strict rule: anybody who adds things like "must_check"
> and "deprecated" had better also be ready and willing to fix all the new
> warnings they cause - you're not allowed to just assume that "somebody
> else will fix it".

Fair enough.  Dave and Arjan, want to fix up the rest of the tree?

thanks,

greg k-h

  reply	other threads:[~2005-09-09 23:02 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-09 22:07 [GIT PATCH] More PCI patches for 2.6.13 Greg KH
2005-09-09 22:37 ` Linus Torvalds
2005-09-09 22:54   ` Greg KH [this message]
2005-09-09 23:22     ` Linus Torvalds
2005-09-09 23:28       ` Linus Torvalds
2005-09-09 23:36       ` Andrew Morton
2005-09-10  0:22         ` Linus Torvalds
2005-09-10  1:27           ` Jeff Garzik
2005-09-10 18:33       ` John W. Linville
2005-09-10 18:53         ` Linus Torvalds
2005-09-11 11:33           ` Pavel Machek
2005-09-10 10:05     ` Arjan van de Ven
  -- strict thread matches above, loose matches on Subject: below --
2005-09-10 21:07 Alan Stern
2005-09-10 21:12 ` Linus Torvalds
2005-09-10 21:58   ` Jeff Garzik
2005-09-10 22:31     ` Andrew Morton
2005-09-10 22:53       ` Linus Torvalds
2005-09-10 23:44         ` Jeff Garzik
2005-09-11  0:02           ` Linus Torvalds
2005-09-11  0:17             ` Jeff Garzik
2005-09-11  0:27               ` Linus Torvalds
2005-09-10 23:02       ` Pavel Machek
2005-09-11 11:38       ` Pavel Machek
2005-09-10 22:32     ` Alistair John Strachan
2005-09-10 23:47       ` Jeff Garzik
2005-09-11  6:47         ` David Woodhouse
2005-09-11  4:41       ` Greg KH
2005-09-11  6:47         ` Alistair John Strachan
2005-09-11  2:34 Gabriel A. Devenyi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050909225421.GA31433@suse.de \
    --to=gregkh@suse.de \
    --cc=akpm@osdl.org \
    --cc=arjan@infradead.org \
    --cc=davej@codemonkey.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.