From: Christoph Hellwig <hch@infradead.org>
To: Mark Haverkamp <markh@osdl.org>
Cc: James Bottomley <James.Bottomley@steeleye.com>,
linux-scsi <linux-scsi@vger.kernel.org>,
Mark Salyzyn <mark_salyzyn@adaptec.com>
Subject: Re: [PATCH 5/8] aacraid: error return checking
Date: Sat, 10 Sep 2005 20:19:25 +0100 [thread overview]
Message-ID: <20050910191925.GC3662@infradead.org> (raw)
In-Reply-To: <1126212624.7479.23.camel@markh1.pdx.osdl.net>
> @@ -929,9 +932,14 @@
> printk(KERN_INFO "Adaptec %s driver (%s)\n",
> AAC_DRIVERNAME, aac_driver_version);
>
> - error = pci_module_init(&aac_pci_driver);
> - if (error)
> + error = pci_register_driver(&aac_pci_driver);
> + if (error < 0 || list_empty(&aac_devices)) {
> + if (error >= 0) {
> + pci_unregister_driver(&aac_pci_driver);
> + error = -ENODEV;
> + }
> return error;
The list_empty check is wrong. I driver should stay loaded even if
no devices have been found.
next prev parent reply other threads:[~2005-09-10 19:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-08 20:50 [PATCH 5/8] aacraid: error return checking Mark Haverkamp
2005-09-10 19:19 ` Christoph Hellwig [this message]
2005-09-12 17:35 ` [PATCH 5/8] aacraid: error return checking (Updated) Mark Haverkamp
2005-09-13 10:05 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2005-09-12 11:19 [PATCH 5/8] aacraid: error return checking Salyzyn, Mark
2005-09-13 10:06 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050910191925.GC3662@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mark_salyzyn@adaptec.com \
--cc=markh@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.