All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: asm-offsets.h is generated in the source tree
Date: Sun, 11 Sep 2005 03:32:03 +0100	[thread overview]
Message-ID: <20050911023203.GH25261@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20050910161917.GA22113@mars.ravnborg.org>

On Sat, Sep 10, 2005 at 06:19:17PM +0200, Sam Ravnborg wrote:
> On Sun, Sep 11, 2005 at 01:20:33AM +1000, Stephen Rothwell wrote:
> > The latest Linus-git tree generates asm-offsets.h in the source tree even
> > if you use O=... I don't know how to fix this, but it means that the
> > source tree cannot be read only.
> My bad. I checked it compiled, not where it saved the file.
> I will have a fix tonight.

BTW, early build stages on uml with O= are still broken, even with that
patch.  The following fixes them, but first chunk is a bad kludge.

What happens:
	a) silentconfig expects to have include/linux in build tree already
created.  Normally that happens earlier, but only by accident.  We need to
force that somehow and the way I'd done it is almost certainly wrong - it
should be in top-level makefile, to start with.  Suggestions?
	b) kernel-offsets.h needs symlinks already in place.  prepare1 does
everything we need, so that dependency is probably the right thing (the second
chunk).

diff -urN RC13-git10-base/arch/um/Makefile current/arch/um/Makefile
--- RC13-git10-base/arch/um/Makefile	2005-09-10 19:28:53.000000000 -0400
+++ current/arch/um/Makefile	2005-09-10 18:34:51.000000000 -0400
@@ -213,6 +213,8 @@
          echo "#endif" )
 endef
 
+include/linux/autoconf.h : include/linux/version.h
+
 $(ARCH_DIR)/include/uml-config.h : include/linux/autoconf.h
 	$(call filechk,umlconfig)
 
@@ -227,9 +229,8 @@
 $(ARCH_DIR)/kernel-offsets.s: $(ARCH_DIR)/sys-$(SUBARCH)/kernel-offsets.c \
 				   $(ARCH_SYMLINKS) \
 				   $(SYS_DIR)/sc.h \
-				   include/asm include/linux/version.h \
-				   include/config/MARKER \
-				   $(ARCH_DIR)/include/user_constants.h
+				   $(ARCH_DIR)/include/user_constants.h \
+				   prepare1
 	$(CC) $(CFLAGS) $(NOSTDINC_FLAGS) $(CPPFLAGS) -S -o $@ $<
 
 $(ARCH_DIR)/kernel-offsets.h: $(ARCH_DIR)/kernel-offsets.s

  reply	other threads:[~2005-09-11  2:32 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-10 15:20 asm-offsets.h is generated in the source tree Stephen Rothwell
2005-09-10 16:19 ` Sam Ravnborg
2005-09-11  2:32   ` Al Viro [this message]
2005-09-11  8:31     ` Sam Ravnborg
2005-09-11 15:45       ` Al Viro
2005-09-11 17:04         ` Sam Ravnborg
2005-09-11 21:29           ` Al Viro
2005-09-11 22:03             ` Sam Ravnborg
2005-09-11 23:16               ` Al Viro
2005-09-12 19:15                 ` Sam Ravnborg
2005-09-13  6:30                   ` Al Viro
2005-09-13  6:48                     ` Kyle Moffett
2005-09-13  6:53                       ` Keith Owens
2005-09-13  6:58                         ` Kyle Moffett
2005-09-13 21:55                     ` Al Viro
2005-09-15  1:07                   ` Al Viro
2005-09-10 19:08 ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050911023203.GH25261@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.