From: Paul Jackson <pj@sgi.com>
To: Nikita Danilov <nikita@clusterfs.com>
Cc: akpm@osdl.org, torvalds@osdl.org, Simon.Derr@bull.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpuset semaphore depth check optimize
Date: Mon, 12 Sep 2005 06:25:48 -0700 [thread overview]
Message-ID: <20050912062548.4c40395e.pj@sgi.com> (raw)
In-Reply-To: <17189.27398.848822.787487@gargle.gargle.HOWL>
Nikita wrote:
> static void cpuset_{down,up}(void);
I started with (void) calls when I first wrote this hack,
then changed it to taking a semaphore pointer, intentionally.
The calls:
cpuset_down(&cpuset_sem);
cpuset_up(&cpuset_sem);
exactly replace calls:
down(&cpuset_sem);
up(&cpuset_sem);
I wanted that visual resemblance.
I agree, it's asymmetric, which is not so good.
But the resemblance is more valuable, in my view.
So I will stick with what I've got, unless I see stronger
signs of a concensus to the contrary.
Is that ok?
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.925.600.0401
prev parent reply other threads:[~2005-09-12 13:26 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-12 11:30 [PATCH] cpuset semaphore depth check optimize Paul Jackson
2005-09-12 11:39 ` Andrew Morton
2005-09-12 14:38 ` Linus Torvalds
2005-09-12 15:32 ` Paul Jackson
[not found] ` <17189.39100.862561.865802@gargle.gargle.HOWL>
2005-09-12 15:38 ` Paul Jackson
2005-09-13 7:04 ` Ingo Molnar
2005-09-13 22:21 ` Paul Jackson
2005-09-12 14:51 ` Paul Jackson
2005-09-12 17:07 ` Roman Zippel
[not found] ` <20050912153135.3812d8e2.pj@sgi.com>
2005-09-13 11:42 ` Roman Zippel
2005-09-13 17:37 ` Paul Jackson
2005-09-14 6:01 ` Paul Jackson
2005-09-14 15:56 ` Roman Zippel
2005-09-14 19:46 ` Paul Jackson
2005-09-15 10:51 ` Roman Zippel
2005-09-15 17:45 ` Paul Jackson
2005-09-15 19:18 ` Paul Jackson
2005-09-17 2:06 ` Roman Zippel
2005-09-17 2:27 ` Roman Zippel
2005-09-20 7:57 ` Paul Jackson
2005-09-20 12:05 ` Robin Holt
2005-09-20 12:21 ` Robin Holt
2005-09-20 13:10 ` Simon Derr
2005-09-20 14:22 ` Paul Jackson
2005-09-20 14:54 ` Robin Holt
2005-09-20 15:07 ` Linus Torvalds
2005-09-20 15:14 ` Paul Jackson
2005-09-20 15:17 ` Simon Derr
2005-09-12 11:48 ` Nikita Danilov
2005-09-12 13:25 ` Paul Jackson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050912062548.4c40395e.pj@sgi.com \
--to=pj@sgi.com \
--cc=Simon.Derr@bull.net \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikita@clusterfs.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.