From: Michael Vrable <mvrable@cs.ucsd.edu>
To: xen-devel@lists.xensource.com
Subject: [PATCH] Small fix for shadow_remove_all_access_in_page
Date: Mon, 12 Sep 2005 19:38:45 -0700 [thread overview]
Message-ID: <20050913023845.GA4764@vrable.net> (raw)
Here's a fairly simple patch to correct a bug I hit when experimenting
with VM forking earlier. Let me know if there's anything wrong with the
changeset; this is the first time I've tried exporting a changeset from
Mercurial.
--Michael Vrable
# HG changeset patch
# User Michael Vrable <mvrable@cs.ucsd.edu>
# Node ID df9609e384a4a819a69d01556b8231b842b04050
# Parent d8637529dafff3c610e4bb31349d4ae00a23a18e
Fix a bug in shadow_remove_all_access_in_page.
Fixes a fairly obvious bug, in which an if statement was reversed. The
bug has been present for a while, so apparently this code isn't well
tested.
Signed-off-by: Michael Vrable <mvrable@cs.ucsd.edu>
diff -r d8637529daff -r df9609e384a4 xen/arch/x86/shadow32.c
--- a/xen/arch/x86/shadow32.c Mon Sep 12 21:42:26 2005
+++ b/xen/arch/x86/shadow32.c Tue Sep 13 02:00:19 2005
@@ -2226,7 +2226,7 @@
for (i = 0; i < L1_PAGETABLE_ENTRIES; i++)
{
- if ( unlikely(!l1e_has_changed(pl1e[i], match, flags) == 0) )
+ if ( unlikely(!l1e_has_changed(pl1e[i], match, flags)) )
{
l1_pgentry_t ol2e = pl1e[i];
pl1e[i] = l1e_empty();
diff -r d8637529daff -r df9609e384a4 xen/arch/x86/shadow_public.c
--- a/xen/arch/x86/shadow_public.c Mon Sep 12 21:42:26 2005
+++ b/xen/arch/x86/shadow_public.c Tue Sep 13 02:00:19 2005
@@ -1634,7 +1634,7 @@
for (i = 0; i < L1_PAGETABLE_ENTRIES; i++)
{
- if ( unlikely(!l1e_has_changed(pl1e[i], match, flags) == 0) )
+ if ( unlikely(!l1e_has_changed(pl1e[i], match, flags)) )
{
l1_pgentry_t ol2e = pl1e[i];
pl1e[i] = l1e_empty();
next reply other threads:[~2005-09-13 2:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-13 2:38 Michael Vrable [this message]
2005-09-13 9:15 ` [PATCH] Small fix for shadow_remove_all_access_in_page Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050913023845.GA4764@vrable.net \
--to=mvrable@cs.ucsd.edu \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.