From: Ladislav Michl <ladis@linux-mips.org>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] PATCH for cmd_mem.c:do_mem_mtest()
Date: Tue, 13 Sep 2005 18:31:14 +0200 [thread overview]
Message-ID: <20050913163114.GA19366@orphique> (raw)
In-Reply-To: <20050913161856.03D1B352B8B@atlas.denx.de>
On Tue, Sep 13, 2005 at 06:18:56PM +0200, Wolfgang Denk wrote:
> > ChangeLog:
> > * Patch by Andrew Dyer, 13 September 2005:
> > if CFG_ALT_MEMTEST is defined without
> > CFG_MEMTEST_SCRATCH, cmd_mem.c
> > code will dereference a null pointer. Change
>
> No, it does not. It just points to address 0x0000. This is a
> perfectly valid address on many systems.
I sent patch to mailing list few months ago which changes NULL to
0x00000000 and adds some comment to avoid such confusion (I burned
my fingers the same way :-)).
ftp://ftp.linux-mips.org/pub/linux/mips/people/ladis/u-boot/cmd_mem_dummy_addr.diff
Best regards,
ladis
next prev parent reply other threads:[~2005-09-13 16:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-13 16:09 [U-Boot-Users] PATCH for cmd_mem.c:do_mem_mtest() Andrew Dyer
2005-09-13 16:18 ` Wolfgang Denk
2005-09-13 16:31 ` Ladislav Michl [this message]
2005-09-13 18:04 ` Wolfgang Denk
2005-09-13 19:26 ` [U-Boot-Users] ppcboot_stage2 manju mahajan
2005-10-03 16:52 ` Sam Pham
2005-10-03 19:37 ` Wolfgang Denk
2005-10-04 15:49 ` Sam Pham
2005-09-14 8:09 ` [U-Boot-Users] PATCH for cmd_mem.c:do_mem_mtest() Ladislav Michl
2006-07-22 19:03 ` Wolfgang Denk
2005-09-13 16:55 ` Andrew Dyer
2005-09-13 18:27 ` Wolfgang Denk
2005-09-13 18:43 ` Jerry Van Baren
2005-09-13 19:54 ` Wolfgang Denk
2005-09-13 20:08 ` Jerry Van Baren
2005-09-13 20:26 ` Andrew Dyer
2005-09-13 21:08 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050913163114.GA19366@orphique \
--to=ladis@linux-mips.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.