From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adam Kropelin Date: Tue, 13 Sep 2005 22:43:21 +0000 Subject: [PATCH] ibmphp: Use dword accessors for PCI_ROM_ADDRESS Message-Id: <20050913191126.B10911@mail.kroptech.com> List-Id: In-Reply-To: <20050913182550.A10911@mail.kroptech.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: gregkh@suse.de Cc: linux-hotplug-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org PCI_ROM_ADDRESS is a 32 bit register and as such should be accessed using pci_bus_{read,write}_config_dword(). A recent audit of drivers/ turned up several cases of byte- and word-sized accesses. The harmful ones were fixed by Linus directly. This patches up one of the remaining harmless-but-still-wrong cases caught in the dragnet. Signed-off-by: Adam Kropelin --- linux-2.6.14-rc1.orig/drivers/pci/hotplug/ibmphp_pci.c 2005-06-17 15:48:29.000000000 -0400 +++ linux-2.6.14-rc1/drivers/pci/hotplug/ibmphp_pci.c 2005-09-13 11:49:10.000000000 -0400 @@ -558,7 +558,7 @@ pci_bus_write_config_byte (ibmphp_pci_bus, devfn, PCI_CACHE_LINE_SIZE, CACHE); pci_bus_write_config_byte (ibmphp_pci_bus, devfn, PCI_LATENCY_TIMER, LATENCY); - pci_bus_write_config_word (ibmphp_pci_bus, devfn, PCI_ROM_ADDRESS, 0x00L); + pci_bus_write_config_dword (ibmphp_pci_bus, devfn, PCI_ROM_ADDRESS, 0x00L); pci_bus_write_config_word (ibmphp_pci_bus, devfn, PCI_COMMAND, DEVICEENABLE); return 0; ------------------------------------------------------- SF.Net email is sponsored by: Tame your development challenges with Apache's Geronimo App Server. Download it for free - -and be entered to win a 42" plasma tv or your very own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932208AbVIMWmo (ORCPT ); Tue, 13 Sep 2005 18:42:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932264AbVIMWmo (ORCPT ); Tue, 13 Sep 2005 18:42:44 -0400 Received: from ms-smtp-03.nyroc.rr.com ([24.24.2.57]:60327 "EHLO ms-smtp-03.nyroc.rr.com") by vger.kernel.org with ESMTP id S932208AbVIMWmn (ORCPT ); Tue, 13 Sep 2005 18:42:43 -0400 Date: Tue, 13 Sep 2005 19:11:26 -0400 From: Adam Kropelin To: gregkh@suse.de Cc: linux-hotplug-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: [PATCH] ibmphp: Use dword accessors for PCI_ROM_ADDRESS Message-ID: <20050913191126.B10911@mail.kroptech.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20050913182550.A10911@mail.kroptech.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org PCI_ROM_ADDRESS is a 32 bit register and as such should be accessed using pci_bus_{read,write}_config_dword(). A recent audit of drivers/ turned up several cases of byte- and word-sized accesses. The harmful ones were fixed by Linus directly. This patches up one of the remaining harmless-but-still-wrong cases caught in the dragnet. Signed-off-by: Adam Kropelin --- linux-2.6.14-rc1.orig/drivers/pci/hotplug/ibmphp_pci.c 2005-06-17 15:48:29.000000000 -0400 +++ linux-2.6.14-rc1/drivers/pci/hotplug/ibmphp_pci.c 2005-09-13 11:49:10.000000000 -0400 @@ -558,7 +558,7 @@ pci_bus_write_config_byte (ibmphp_pci_bus, devfn, PCI_CACHE_LINE_SIZE, CACHE); pci_bus_write_config_byte (ibmphp_pci_bus, devfn, PCI_LATENCY_TIMER, LATENCY); - pci_bus_write_config_word (ibmphp_pci_bus, devfn, PCI_ROM_ADDRESS, 0x00L); + pci_bus_write_config_dword (ibmphp_pci_bus, devfn, PCI_ROM_ADDRESS, 0x00L); pci_bus_write_config_word (ibmphp_pci_bus, devfn, PCI_COMMAND, DEVICEENABLE); return 0;