From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc64-dev@ozlabs.org
Cc: "linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>
Subject: Re: PATCH powerpc: Merge asm-ppc*/sections.h
Date: Wed, 14 Sep 2005 04:35:21 +0200 [thread overview]
Message-ID: <200509140435.21916.arnd@arndb.de> (raw)
In-Reply-To: <1126644202.11056.59.camel@cashmere.sps.mot.com>
On Dinsdag 13 September 2005 22:43, Jon Loeliger wrote:
> Here is a patch to merge asm-ppc*/sections.h.
>
> If anyone knows if we can do better here,
> please feel free to abuse, er, let me know!
Ok, I don't like this patch. IMHO for the architecture merge, we should
have a common implementation of this, either always using per-platform
sections or never using them, meaning that we get rid of this file.
At the very least, the __*func() macros should go away, they are completely
bogus.
Using the sections in arch/powerpc has the obvious advantage that it
reduces the size of the running kernel, but also has a certain amount
of bug-potential or at least makes the code slightly more ugly.
It is also easier to remove the feature in ppc than adding it in ppc64.
The users of the ppc64 function in_kernel_text() can probably be converted
to the generic is_kernel_text() function.
Arnd <><
next prev parent reply other threads:[~2005-09-14 2:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-13 20:43 PATCH powerpc: Merge asm-ppc*/sections.h Jon Loeliger
2005-09-14 2:35 ` Arnd Bergmann [this message]
2005-09-14 13:46 ` Jon Loeliger
2005-09-15 11:09 ` Paul Mackerras
2005-09-15 17:07 ` Jon Loeliger
2005-09-15 17:28 ` Kumar Gala
2005-09-15 20:57 ` Gabriel Paubert
2005-09-15 21:21 ` Dan Malek
2005-09-15 22:00 ` Paul Mackerras
2005-09-15 22:37 ` Gabriel Paubert
2005-09-16 14:46 ` Jon Loeliger
2005-09-18 1:28 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200509140435.21916.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=linuxppc64-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.