All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Dominik Brodowski <linux@dominikbrodowski.net>,
	linux-ppc-embedded <linuxppc-embedded@ozlabs.org>,
	linux-kernel@vger.kernel.org,
	Pantelis Antoniou <panto@intracom.gr>,
	Dan Malek <dan@embeddededge.com>
Subject: Re: [PATCH] MPC8xx PCMCIA driver
Date: Wed, 14 Sep 2005 11:11:31 -0300	[thread overview]
Message-ID: <20050914141131.GA6830@dmt.cnet> (raw)
In-Reply-To: <20050901085319.GB6285@isilmar.linta.de>

On Thu, Sep 01, 2005 at 10:53:19AM +0200, Dominik Brodowski wrote:

> > +typedef struct  {
> > +	u_int regbit;
> > +	u_int eventbit;
> > +} event_table_t;
> 
> No typedefs, please.

OK, I've converted it to a plain "struct".

I think this code is just following PCMCIA style:

typedef struct pccard_mem_map { 
	u_char	map;
	u_char	flags;
	u_short	speed;
	u_long	static_start;
	u_int	card_start;
	struct resource *res;
} pccard_mem_map;

Any reason why this typedef and similar ones in ss.h 
are wanted? 

PCMCIA is also using u_xxx "weird data types" extensively.

  parent reply	other threads:[~2005-09-14 14:17 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-30  2:48 [PATCH] MPC8xx PCMCIA driver Marcelo Tosatti
2005-08-30  2:48 ` Marcelo Tosatti
2005-08-30  3:39 ` Jeff Garzik
2005-08-30  3:39   ` Jeff Garzik
2005-08-30  3:53   ` Marcelo Tosatti
2005-08-30  3:53     ` Marcelo Tosatti
2005-08-30  4:32     ` Paul Mackerras
2005-08-30  4:32       ` Paul Mackerras
2005-08-30 15:07       ` Marcelo Tosatti
2005-08-30 15:07         ` Marcelo Tosatti
2005-08-30  4:33     ` Jeff Garzik
2005-08-30  4:33       ` Jeff Garzik
2005-08-30  7:06 ` Russell King
2005-08-30  7:06   ` Russell King
2005-09-01  8:53 ` Dominik Brodowski
2005-09-01  8:53   ` Dominik Brodowski
2005-09-01 11:44   ` Magnus Damm
2005-09-01 11:44     ` Magnus Damm
2005-09-01 14:51   ` Marcelo Tosatti
2005-09-14 14:11   ` Marcelo Tosatti [this message]
2005-09-14 14:27     ` Dominik Brodowski
2005-09-14 14:27       ` Dominik Brodowski
2005-09-14 18:21       ` Marcelo Tosatti
2005-09-14 18:21         ` Marcelo Tosatti
2005-09-14 18:46         ` Jeff Garzik
2005-09-14 18:46           ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050914141131.GA6830@dmt.cnet \
    --to=marcelo.tosatti@cyclades.com \
    --cc=dan@embeddededge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@dominikbrodowski.net \
    --cc=linuxppc-embedded@ozlabs.org \
    --cc=panto@intracom.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.