From: Daniel Jacobowitz <dan@debian.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: "Markus F.X.J. Oberhumer" <markus@oberhumer.com>,
linux-kernel@vger.kernel.org, Andi Kleen <ak@suse.de>
Subject: Re: [PATCH] i386: fix stack alignment for signal handlers
Date: Wed, 14 Sep 2005 10:22:04 -0400 [thread overview]
Message-ID: <20050914142204.GA19731@nevyn.them.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0509131649060.26803@g5.osdl.org>
On Tue, Sep 13, 2005 at 04:52:30PM -0700, Linus Torvalds wrote:
> Your test program does seems to imply that gcc wants the alignment before
> the return address (ie it prints out an address that is 4 bytes offset),
> but on the other hand I'm not even sure how careful gcc is about this
> alignment thing at all.
Very, on architectures where the ABI requires alignment. E.G. for
vector register loads that require 16-byte alignment to avoid a trap.
The comment for the relevant bits of the GCC configuration says it
won't assume this for x86, but I believe that comment is out of date.
I think it'll assume 16-byte alignment on entrance to non-main()
functions.
> In the "main()" function, gcc will actually generate a "andl $-16,%esp" to
> force the alignment, but ot in the handler function. Just a gcc special
> case? Random luck?
Special case. This is only done for main().
--
Daniel Jacobowitz
CodeSourcery, LLC
next prev parent reply other threads:[~2005-09-14 14:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-13 20:55 [PATCH] i386: fix stack alignment for signal handlers Markus F.X.J. Oberhumer
2005-09-13 22:53 ` Linus Torvalds
2005-09-13 23:30 ` Markus F.X.J. Oberhumer
2005-09-13 23:52 ` Linus Torvalds
2005-09-14 1:39 ` Markus F.X.J. Oberhumer
2005-09-14 4:54 ` Andi Kleen
2005-09-14 14:22 ` Daniel Jacobowitz [this message]
2005-09-14 14:55 ` Linus Torvalds
2005-09-14 15:44 ` Andi Kleen
2005-10-09 16:54 ` Markus F.X.J. Oberhumer
2005-10-09 16:57 ` Andi Kleen
2005-10-09 17:06 ` Markus F.X.J. Oberhumer
2005-10-11 0:23 ` Markus F.X.J. Oberhumer
2005-09-14 20:11 ` J.A. Magallon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050914142204.GA19731@nevyn.them.org \
--to=dan@debian.org \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=markus@oberhumer.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.