From: Greg KH <greg@kroah.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
linux-usb-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, Karsten Keil <kkeil@suse.de>
Subject: Re: [linux-usb-devel] URB_ASYNC_UNLINK b0rkage
Date: Sun, 18 Sep 2005 20:02:06 -0700 [thread overview]
Message-ID: <20050919030206.GA16966@kroah.com> (raw)
In-Reply-To: <20050918223811.GA24046@mipter.zuzino.mipt.ru>
On Mon, Sep 19, 2005 at 02:38:12AM +0400, Alexey Dobriyan wrote:
> > In my kernel tree, the st5481 source files don't include the lines you
> > show. What source version are you using?
>
> 23 hours ago:
>
> commit 61ffcafafb3d985e1ab8463be0187b421614775c
> Author: Karsten Keil <kkeil@suse.de>
> Date: Sat Sep 17 23:52:42 2005 +0200
>
> [PATCH] Fix ST 5481 USB driver
>
> The old driver was not fully adapted to new USB ABI and does not
> work.
>
> + in->urb[0]->transfer_flags |= URB_ASYNC_UNLINK;
> usb_unlink_urb(in->urb[0]);
> + in->urb[1]->transfer_flags |= URB_ASYNC_UNLINK;
> usb_unlink_urb(in->urb[1]);
And I already pointed out that this patch was wrong, and would cause
build errors...
thanks,
greg k-h
prev parent reply other threads:[~2005-09-19 3:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-18 19:05 URB_ASYNC_UNLINK b0rkage Alexey Dobriyan
2005-09-18 21:30 ` [linux-usb-devel] " Alan Stern
2005-09-18 22:38 ` Alexey Dobriyan
2005-09-19 3:02 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050919030206.GA16966@kroah.com \
--to=greg@kroah.com \
--cc=adobriyan@gmail.com \
--cc=kkeil@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.