From: Andrew Morton <akpm@osdl.org>
To: Vadim Lobanov <vlobanov@speakeasy.net>
Cc: pazke@donpac.ru, colin@realtek.com.tw, linux-kernel@vger.kernel.org
Subject: Re: CONFIG_PRINTK doesn't makes size smaller
Date: Tue, 20 Sep 2005 01:03:05 -0700 [thread overview]
Message-ID: <20050920010305.745d5ccf.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0509200047120.3173@shell2.speakeasy.net>
Vadim Lobanov <vlobanov@speakeasy.net> wrote:
>
> On Tue, 20 Sep 2005, Andrey Panin wrote:
>
> > On 263, 09 20, 2005 at 02:14:55PM +0800, colin wrote:
> > >
> > > Hi there,
> > > I tried to make kernel with CONFIG_PRINTK off. I considered it should become
> > > smaller, but it didn't because it actually isn't an empty function, and
> > > there are many copies of it in vmlinux, not just one. Here is its
> > > definition:
> > > static inline int printk(const char *s, ...) { return 0; }
> > >
> > > I change the definition to this and it can greatly reduce the size by about
> > > 5%:
> > > #define printk(...) do {} while (0)
> > > However, this definition would lead to error in some situations. For
> > > example:
> > > 1. (printk)
> > > 2. ret = printk
> > >
> > > I hope someone could suggest a better definition of printk that can both
> > > make printk smaller and eliminate errors.
> >
> > What about the macro below ?
> >
> > #define printk(...) ({ do { } while(0); 0; })
>
> So what does the do-while loop give us in the above case? In other
> words, why not just do the following...?
>
> #define printk(...) ({ 0; })
>
You may find that when printk() is a static inline there are still copies
of the control string in the generated kernel image:
printk("foo %d\n", bar());
must still evaluate bar() and may cause "foo %d\n" to turn up in vmlinux.
IIRC later versions of gcc do remove the unreferenced string.
If printk is a macro, it all of course disappears.
next prev parent reply other threads:[~2005-09-20 8:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-20 6:14 CONFIG_PRINTK doesn't makes size smaller colin
2005-09-20 6:38 ` Andrey Panin
2005-09-20 7:48 ` Vadim Lobanov
2005-09-20 8:03 ` Andrew Morton [this message]
2005-09-20 9:11 ` colin
2005-09-20 9:02 ` Andrey Panin
2005-09-20 15:41 ` Vadim Lobanov
2005-09-20 8:30 ` Denis Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050920010305.745d5ccf.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=colin@realtek.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=pazke@donpac.ru \
--cc=vlobanov@speakeasy.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.