From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.92] helo=mail.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1EHvWs-0006qx-PB for user-mode-linux-devel@lists.sourceforge.net; Tue, 20 Sep 2005 20:44:18 -0700 Received: from zeniv.linux.org.uk ([195.92.253.2]) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1EHvWs-0004Gu-Ee for user-mode-linux-devel@lists.sourceforge.net; Tue, 20 Sep 2005 20:44:18 -0700 From: Al Viro Message-ID: <20050921034416.GW7992@ftp.linux.org.uk> References: <20050918141006.31461.23599.stgit@zion.home.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050918141006.31461.23599.stgit@zion.home.lan> Subject: [uml-devel] Re: [PATCH 11/12] HPPFS: add dentry_ops->d_revalidate Sender: user-mode-linux-devel-admin@lists.sourceforge.net Errors-To: user-mode-linux-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Id: The user-mode Linux development list List-Post: List-Help: List-Subscribe: , List-Archive: Date: Wed, 21 Sep 2005 04:44:16 +0100 To: Paolo 'Blaisorblade' Giarrusso Cc: Antoine Martin , Al Viro , Jeff Dike , user-mode-linux-devel@lists.sourceforge.net, LKML On Sun, Sep 18, 2005 at 04:10:07PM +0200, Paolo 'Blaisorblade' Giarrusso wrote: > +static int hppfs_d_revalidate(struct dentry * dentry, struct nameidata * nd) > +{ > + int (*d_revalidate)(struct dentry *, struct nameidata *); > + struct dentry *proc_dentry; > + > + proc_dentry = HPPFS_I(dentry->d_inode)->proc_dentry; > + if (proc_dentry->d_op && proc_dentry->d_op->d_revalidate) > + d_revalidate = proc_dentry->d_op->d_revalidate; > + else > + return 1; /* "Still valid" code */ > + > + return (*d_revalidate)(proc_dentry, nd); > +} Ahem... Guess what that will do with negative dentry? ------------------------------------------------------- SF.Net email is sponsored by: Tame your development challenges with Apache's Geronimo App Server. Download it for free - -and be entered to win a 42" plasma tv or your very own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750957AbVIUDoS (ORCPT ); Tue, 20 Sep 2005 23:44:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750968AbVIUDoS (ORCPT ); Tue, 20 Sep 2005 23:44:18 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:25778 "EHLO ZenIV.linux.org.uk") by vger.kernel.org with ESMTP id S1750936AbVIUDoS (ORCPT ); Tue, 20 Sep 2005 23:44:18 -0400 Date: Wed, 21 Sep 2005 04:44:16 +0100 From: Al Viro To: "Paolo 'Blaisorblade' Giarrusso" Cc: Antoine Martin , Al Viro , Jeff Dike , user-mode-linux-devel@lists.sourceforge.net, LKML Subject: Re: [PATCH 11/12] HPPFS: add dentry_ops->d_revalidate Message-ID: <20050921034416.GW7992@ftp.linux.org.uk> References: <20050918141006.31461.23599.stgit@zion.home.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050918141006.31461.23599.stgit@zion.home.lan> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 18, 2005 at 04:10:07PM +0200, Paolo 'Blaisorblade' Giarrusso wrote: > +static int hppfs_d_revalidate(struct dentry * dentry, struct nameidata * nd) > +{ > + int (*d_revalidate)(struct dentry *, struct nameidata *); > + struct dentry *proc_dentry; > + > + proc_dentry = HPPFS_I(dentry->d_inode)->proc_dentry; > + if (proc_dentry->d_op && proc_dentry->d_op->d_revalidate) > + d_revalidate = proc_dentry->d_op->d_revalidate; > + else > + return 1; /* "Still valid" code */ > + > + return (*d_revalidate)(proc_dentry, nd); > +} Ahem... Guess what that will do with negative dentry?