From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.92] helo=mail.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1EIC98-0007Jh-56 for user-mode-linux-devel@lists.sourceforge.net; Wed, 21 Sep 2005 14:28:54 -0700 Received: from lakshmi.addtoit.com ([198.99.130.6] helo=lakshmi.solana.com) by mail.sourceforge.net with esmtp (Exim 4.44) id 1EIC96-0001Jr-PD for user-mode-linux-devel@lists.sourceforge.net; Wed, 21 Sep 2005 14:28:54 -0700 From: Jeff Dike Subject: Re: [uml-devel] [PATCH 08/10] uml: Fix GFP_ flags usage Message-ID: <20050921205227.GC9918@ccure.user-mode-linux.org> References: <200509211923.21861.blaisorblade@yahoo.it> <20050921172920.10219.29856.stgit@zion.home.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050921172920.10219.29856.stgit@zion.home.lan> Sender: user-mode-linux-devel-admin@lists.sourceforge.net Errors-To: user-mode-linux-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Id: The user-mode Linux development list List-Post: List-Help: List-Subscribe: , List-Archive: Date: Wed, 21 Sep 2005 16:52:27 -0400 To: Paolo 'Blaisorblade' Giarrusso Cc: user-mode-linux-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org On Wed, Sep 21, 2005 at 07:29:21PM +0200, Paolo 'Blaisorblade' Giarrusso wrote: > - if(atomic) flags |= GFP_ATOMIC; > + if (atomic) > + flags = GFP_ATOMIC; We should take a careful look at where this is called from, and see if we can get rid of the atomic business altogether. Jeff ------------------------------------------------------- SF.Net email is sponsored by: Tame your development challenges with Apache's Geronimo App Server. Download it for free - -and be entered to win a 42" plasma tv or your very own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964822AbVIUV2s (ORCPT ); Wed, 21 Sep 2005 17:28:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964965AbVIUV2s (ORCPT ); Wed, 21 Sep 2005 17:28:48 -0400 Received: from lakshmi.addtoit.com ([198.99.130.6]:15624 "EHLO lakshmi.solana.com") by vger.kernel.org with ESMTP id S964822AbVIUV2s (ORCPT ); Wed, 21 Sep 2005 17:28:48 -0400 Date: Wed, 21 Sep 2005 16:52:27 -0400 From: Jeff Dike To: "Paolo 'Blaisorblade' Giarrusso" Cc: user-mode-linux-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [uml-devel] [PATCH 08/10] uml: Fix GFP_ flags usage Message-ID: <20050921205227.GC9918@ccure.user-mode-linux.org> References: <200509211923.21861.blaisorblade@yahoo.it> <20050921172920.10219.29856.stgit@zion.home.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050921172920.10219.29856.stgit@zion.home.lan> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 21, 2005 at 07:29:21PM +0200, Paolo 'Blaisorblade' Giarrusso wrote: > - if(atomic) flags |= GFP_ATOMIC; > + if (atomic) > + flags = GFP_ATOMIC; We should take a careful look at where this is called from, and see if we can get rid of the atomic business altogether. Jeff