From: Ingo Molnar <mingo@elte.hu>
To: Andi Kleen <ak@muc.de>
Cc: Zachary Amsden <zach@vmware.com>,
Linus Torvalds <torvalds@osdl.org>,
Jeffrey Sheldon <jeffshel@vmware.com>,
Ole Agesen <agesen@vmware.com>, Shai Fultheim <shai@scalex86.org>,
Andrew Morton <akpm@odsl.org>, Jack Lo <jlo@vmware.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Virtualization Mailing List <virtualization@lists.osdl.org>,
Chris Wright <chrisw@osdl.org>, Martin Bligh <mbligh@mbligh.org>,
Pratap Subrahmanyam <pratap@vmware.com>,
Christopher Li <chrisl@vmware.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Zwane Mwaikambo <zwane@arm.linux.org.uk>
Subject: Re: [PATCH 3/3] Gdt page isolation
Date: Thu, 22 Sep 2005 15:34:02 +0200 [thread overview]
Message-ID: <20050922133402.GA19011@elte.hu> (raw)
In-Reply-To: <20050922131714.GA97170@muc.de>
* Andi Kleen <ak@muc.de> wrote:
> > * This grunge runs the startup process for
> > * the targeted processor.
> > */
> > + cpu_gdt_descr[cpu].address = __get_free_page(GFP_KERNEL|__GFP_ZERO);
>
> I can see why don't check it for NULL, but it's a ugly reason and
> would be better fixed. It at least needs a comment.
it's so early in the bootup that any failure here would probably be
fatal anyway. But yeah, a comment would be nice.
> -Andi (who would still prefer just going back to the array in head.S -
> would work as well and waste less memory)
that doesnt really solve the problem for e.g. Xen, which needs a
separate page for each GDT. (xenolinux is a separate arch right now, but
it will/should be merged back into its base architectures) So why not
solve all the problems at once?
Ingo
next prev parent reply other threads:[~2005-09-22 13:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-22 7:49 [PATCH 3/3] Gdt page isolation Zachary Amsden
2005-09-22 8:59 ` Ingo Molnar
2005-09-22 13:17 ` Andi Kleen
2005-09-22 13:34 ` Ingo Molnar [this message]
2005-09-22 13:38 ` Andi Kleen
2005-09-23 19:00 ` Zachary Amsden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050922133402.GA19011@elte.hu \
--to=mingo@elte.hu \
--cc=agesen@vmware.com \
--cc=ak@muc.de \
--cc=akpm@odsl.org \
--cc=chrisl@vmware.com \
--cc=chrisw@osdl.org \
--cc=hpa@zytor.com \
--cc=jeffshel@vmware.com \
--cc=jlo@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@mbligh.org \
--cc=pratap@vmware.com \
--cc=shai@scalex86.org \
--cc=torvalds@osdl.org \
--cc=virtualization@lists.osdl.org \
--cc=zach@vmware.com \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.