From: Matthew Wilcox <matthew@wil.cx>
To: linux-ia64@vger.kernel.org
Subject: Re: [Lhms-devel] [PATCH 4/4] V4 ia64 SPARSEMEM - SPARSEMEM code changes
Date: Thu, 22 Sep 2005 17:13:40 +0000 [thread overview]
Message-ID: <20050922171340.GG26389@parisc-linux.org> (raw)
In-Reply-To: <1127406976.10664.52.camel@localhost>
On Thu, Sep 22, 2005 at 09:36:16AM -0700, Dave Hansen wrote:
> >
> > - return (i < num_node_memblks) ? node_memblk[i].nid : (num_node_memblks ? -1 : 0);
> > + return (i < num_node_memblks) ?
> > + node_memblk[i].nid : (num_node_memblks ? -1 : 0);
> > }
>
> Looks like just a whitespace change.
But really far less radical than it deserves ... nested conditional
expressions? Come on. How about:
if (i < num_node_memblks)
return node_memblk[i].nid;
if (num_node_memblks)
return -1;
return 0;
next prev parent reply other threads:[~2005-09-22 17:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-22 16:36 [Lhms-devel] [PATCH 4/4] V4 ia64 SPARSEMEM - SPARSEMEM code Dave Hansen
2005-09-22 17:13 ` Matthew Wilcox [this message]
2005-09-22 17:59 ` [Lhms-devel] [PATCH 4/4] V4 ia64 SPARSEMEM - SPARSEMEM code changes Bob Picco
2005-09-22 18:01 ` Bob Picco
2005-09-22 18:05 ` [Lhms-devel] [PATCH 4/4] V4 ia64 SPARSEMEM - SPARSEMEM code Dave Hansen
2005-09-22 18:47 ` [Lhms-devel] [PATCH 4/4] V4 ia64 SPARSEMEM - SPARSEMEM code changes Bob Picco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050922171340.GG26389@parisc-linux.org \
--to=matthew@wil.cx \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.