All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: Christoph Lameter <clameter@engr.sgi.com>
Cc: Andrew Morton <akpm@osdl.org>,
	linux-mm@kvack.org, linux-ia64@vger.kernel.org,
	manfred@colorfulllife.com
Subject: Re: [PATCH] Increase maximum kmalloc size to 256K
Date: Fri, 23 Sep 2005 00:58:04 +0000	[thread overview]
Message-ID: <20050923005804.GI26389@parisc-linux.org> (raw)
In-Reply-To: <Pine.LNX.4.62.0509221329270.18240@schroedinger.engr.sgi.com>

On Thu, Sep 22, 2005 at 01:55:43PM -0700, Christoph Lameter wrote:
> On Thu, 22 Sep 2005, Andrew Morton wrote:
> 
> > Christoph Lameter <clameter@engr.sgi.com> wrote:
> > >
> > >  The workqueue structure can grow larger than 128k under 2.6.14-rc2 (with 
> > >  all debugging features enabled on 64 bit platforms)
> > 
> > Would it be better to use alloc_percpu() in there?  Bearing in mind that
> > one day we'll probably have an alloc_percpu() which incurs one less
> > indirection and which allocates things node-affinely.
> 
> Yes I am working on a patch like that right now. But there is still the 
> danger that other structures also may get big in the future. It would 
> be best to raise the limit.

It would be better to leave the limit alone so other structures which
get ridiculously big are also caught and fixed.

WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <matthew@wil.cx>
To: Christoph Lameter <clameter@engr.sgi.com>
Cc: Andrew Morton <akpm@osdl.org>,
	linux-mm@kvack.org, linux-ia64@vger.kernel.org,
	manfred@colorfulllife.com
Subject: Re: [PATCH] Increase maximum kmalloc size to 256K
Date: Thu, 22 Sep 2005 18:58:04 -0600	[thread overview]
Message-ID: <20050923005804.GI26389@parisc-linux.org> (raw)
In-Reply-To: <Pine.LNX.4.62.0509221329270.18240@schroedinger.engr.sgi.com>

On Thu, Sep 22, 2005 at 01:55:43PM -0700, Christoph Lameter wrote:
> On Thu, 22 Sep 2005, Andrew Morton wrote:
> 
> > Christoph Lameter <clameter@engr.sgi.com> wrote:
> > >
> > >  The workqueue structure can grow larger than 128k under 2.6.14-rc2 (with 
> > >  all debugging features enabled on 64 bit platforms)
> > 
> > Would it be better to use alloc_percpu() in there?  Bearing in mind that
> > one day we'll probably have an alloc_percpu() which incurs one less
> > indirection and which allocates things node-affinely.
> 
> Yes I am working on a patch like that right now. But there is still the 
> danger that other structures also may get big in the future. It would 
> be best to raise the limit.

It would be better to leave the limit alone so other structures which
get ridiculously big are also caught and fixed.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2005-09-23  0:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-22 20:07 [PATCH] Increase maximum kmalloc size to 256K Christoph Lameter
2005-09-22 20:07 ` Christoph Lameter
2005-09-22 20:15 ` Andrew Morton
2005-09-22 20:15   ` Andrew Morton
2005-09-22 20:55   ` Christoph Lameter
2005-09-22 20:55     ` Christoph Lameter
2005-09-23  0:58     ` Matthew Wilcox [this message]
2005-09-23  0:58       ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050923005804.GI26389@parisc-linux.org \
    --to=matthew@wil.cx \
    --cc=akpm@osdl.org \
    --cc=clameter@engr.sgi.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=manfred@colorfulllife.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.