* [PATCH] Increase maximum kmalloc size to 256K
@ 2005-09-22 20:07 ` Christoph Lameter
0 siblings, 0 replies; 8+ messages in thread
From: Christoph Lameter @ 2005-09-22 20:07 UTC (permalink / raw)
To: akpm; +Cc: linux-mm, linux-ia64, manfred
The workqueue structure can grow larger than 128k under 2.6.14-rc2 (with
all debugging features enabled on 64 bit platforms) which will make
kzalloc for workqueue structure entries fail. This patch increases the
maximum slab entry size to 256K.
Signed-off-by: Christoph Lameter <clameter@sgi.com>
Index: linux-2.6.14-rc2/include/linux/kmalloc_sizes.h
=================================--- linux-2.6.14-rc2.orig/include/linux/kmalloc_sizes.h 2005-09-19 20:00:41.000000000 -0700
+++ linux-2.6.14-rc2/include/linux/kmalloc_sizes.h 2005-09-22 12:41:19.000000000 -0700
@@ -19,8 +19,8 @@
CACHE(32768)
CACHE(65536)
CACHE(131072)
-#ifndef CONFIG_MMU
CACHE(262144)
+#ifndef CONFIG_MMU
CACHE(524288)
CACHE(1048576)
#ifdef CONFIG_LARGE_ALLOCS
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] Increase maximum kmalloc size to 256K
@ 2005-09-22 20:07 ` Christoph Lameter
0 siblings, 0 replies; 8+ messages in thread
From: Christoph Lameter @ 2005-09-22 20:07 UTC (permalink / raw)
To: akpm; +Cc: linux-mm, linux-ia64, manfred
The workqueue structure can grow larger than 128k under 2.6.14-rc2 (with
all debugging features enabled on 64 bit platforms) which will make
kzalloc for workqueue structure entries fail. This patch increases the
maximum slab entry size to 256K.
Signed-off-by: Christoph Lameter <clameter@sgi.com>
Index: linux-2.6.14-rc2/include/linux/kmalloc_sizes.h
===================================================================
--- linux-2.6.14-rc2.orig/include/linux/kmalloc_sizes.h 2005-09-19 20:00:41.000000000 -0700
+++ linux-2.6.14-rc2/include/linux/kmalloc_sizes.h 2005-09-22 12:41:19.000000000 -0700
@@ -19,8 +19,8 @@
CACHE(32768)
CACHE(65536)
CACHE(131072)
-#ifndef CONFIG_MMU
CACHE(262144)
+#ifndef CONFIG_MMU
CACHE(524288)
CACHE(1048576)
#ifdef CONFIG_LARGE_ALLOCS
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Increase maximum kmalloc size to 256K
2005-09-22 20:07 ` Christoph Lameter
@ 2005-09-22 20:15 ` Andrew Morton
-1 siblings, 0 replies; 8+ messages in thread
From: Andrew Morton @ 2005-09-22 20:15 UTC (permalink / raw)
To: Christoph Lameter; +Cc: linux-mm, linux-ia64, manfred
Christoph Lameter <clameter@engr.sgi.com> wrote:
>
> The workqueue structure can grow larger than 128k under 2.6.14-rc2 (with
> all debugging features enabled on 64 bit platforms)
Would it be better to use alloc_percpu() in there? Bearing in mind that
one day we'll probably have an alloc_percpu() which incurs one less
indirection and which allocates things node-affinely.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Increase maximum kmalloc size to 256K
@ 2005-09-22 20:15 ` Andrew Morton
0 siblings, 0 replies; 8+ messages in thread
From: Andrew Morton @ 2005-09-22 20:15 UTC (permalink / raw)
To: Christoph Lameter; +Cc: linux-mm, linux-ia64, manfred
Christoph Lameter <clameter@engr.sgi.com> wrote:
>
> The workqueue structure can grow larger than 128k under 2.6.14-rc2 (with
> all debugging features enabled on 64 bit platforms)
Would it be better to use alloc_percpu() in there? Bearing in mind that
one day we'll probably have an alloc_percpu() which incurs one less
indirection and which allocates things node-affinely.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Increase maximum kmalloc size to 256K
2005-09-22 20:15 ` Andrew Morton
@ 2005-09-22 20:55 ` Christoph Lameter
-1 siblings, 0 replies; 8+ messages in thread
From: Christoph Lameter @ 2005-09-22 20:55 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-mm, linux-ia64, manfred
On Thu, 22 Sep 2005, Andrew Morton wrote:
> Christoph Lameter <clameter@engr.sgi.com> wrote:
> >
> > The workqueue structure can grow larger than 128k under 2.6.14-rc2 (with
> > all debugging features enabled on 64 bit platforms)
>
> Would it be better to use alloc_percpu() in there? Bearing in mind that
> one day we'll probably have an alloc_percpu() which incurs one less
> indirection and which allocates things node-affinely.
Yes I am working on a patch like that right now. But there is still the
danger that other structures also may get big in the future. It would
be best to raise the limit.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Increase maximum kmalloc size to 256K
@ 2005-09-22 20:55 ` Christoph Lameter
0 siblings, 0 replies; 8+ messages in thread
From: Christoph Lameter @ 2005-09-22 20:55 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-mm, linux-ia64, manfred
On Thu, 22 Sep 2005, Andrew Morton wrote:
> Christoph Lameter <clameter@engr.sgi.com> wrote:
> >
> > The workqueue structure can grow larger than 128k under 2.6.14-rc2 (with
> > all debugging features enabled on 64 bit platforms)
>
> Would it be better to use alloc_percpu() in there? Bearing in mind that
> one day we'll probably have an alloc_percpu() which incurs one less
> indirection and which allocates things node-affinely.
Yes I am working on a patch like that right now. But there is still the
danger that other structures also may get big in the future. It would
be best to raise the limit.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Increase maximum kmalloc size to 256K
2005-09-22 20:55 ` Christoph Lameter
@ 2005-09-23 0:58 ` Matthew Wilcox
-1 siblings, 0 replies; 8+ messages in thread
From: Matthew Wilcox @ 2005-09-23 0:58 UTC (permalink / raw)
To: Christoph Lameter; +Cc: Andrew Morton, linux-mm, linux-ia64, manfred
On Thu, Sep 22, 2005 at 01:55:43PM -0700, Christoph Lameter wrote:
> On Thu, 22 Sep 2005, Andrew Morton wrote:
>
> > Christoph Lameter <clameter@engr.sgi.com> wrote:
> > >
> > > The workqueue structure can grow larger than 128k under 2.6.14-rc2 (with
> > > all debugging features enabled on 64 bit platforms)
> >
> > Would it be better to use alloc_percpu() in there? Bearing in mind that
> > one day we'll probably have an alloc_percpu() which incurs one less
> > indirection and which allocates things node-affinely.
>
> Yes I am working on a patch like that right now. But there is still the
> danger that other structures also may get big in the future. It would
> be best to raise the limit.
It would be better to leave the limit alone so other structures which
get ridiculously big are also caught and fixed.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Increase maximum kmalloc size to 256K
@ 2005-09-23 0:58 ` Matthew Wilcox
0 siblings, 0 replies; 8+ messages in thread
From: Matthew Wilcox @ 2005-09-23 0:58 UTC (permalink / raw)
To: Christoph Lameter; +Cc: Andrew Morton, linux-mm, linux-ia64, manfred
On Thu, Sep 22, 2005 at 01:55:43PM -0700, Christoph Lameter wrote:
> On Thu, 22 Sep 2005, Andrew Morton wrote:
>
> > Christoph Lameter <clameter@engr.sgi.com> wrote:
> > >
> > > The workqueue structure can grow larger than 128k under 2.6.14-rc2 (with
> > > all debugging features enabled on 64 bit platforms)
> >
> > Would it be better to use alloc_percpu() in there? Bearing in mind that
> > one day we'll probably have an alloc_percpu() which incurs one less
> > indirection and which allocates things node-affinely.
>
> Yes I am working on a patch like that right now. But there is still the
> danger that other structures also may get big in the future. It would
> be best to raise the limit.
It would be better to leave the limit alone so other structures which
get ridiculously big are also caught and fixed.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2005-09-23 0:58 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-09-22 20:07 [PATCH] Increase maximum kmalloc size to 256K Christoph Lameter
2005-09-22 20:07 ` Christoph Lameter
2005-09-22 20:15 ` Andrew Morton
2005-09-22 20:15 ` Andrew Morton
2005-09-22 20:55 ` Christoph Lameter
2005-09-22 20:55 ` Christoph Lameter
2005-09-23 0:58 ` Matthew Wilcox
2005-09-23 0:58 ` Matthew Wilcox
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.