All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Jon Loeliger <jdl@freescale.com>
Cc: linuxppc-dev@ozlabs.org, linuxppc64-dev@ozlabs.org
Subject: Re: PATCH powerpc Merge asm-ppc*/seccomp.h
Date: Fri, 23 Sep 2005 11:08:09 +0200	[thread overview]
Message-ID: <20050923090809.GA31688@lst.de> (raw)
In-Reply-To: <E1EIVwC-0001IQ-5s@jdl.com>

On Thu, Sep 22, 2005 at 01:36:52PM -0500, Jon Loeliger wrote:
> So, like, the other day Christoph Hellwig mumbled:
> > > +#include <linux/thread_info.h>
> > > +
> > > +#if defined(__powerpc64__) && !defined(TIF_32BIT)
> > > +#error "unexpected TIF_32BIT on ppc64"
> > > +#endif
> > 
> > just kill this check, it's rather pointless
> 
> OK.
> 
> But keep the #include?  It's actually the part
> that is defining TIF_32BIT for ppc64 (indirectly
> through linux/thread_info.h and asm/thread_info.h).
> Won't those bits be needed still?

I'm not sure.  This header definitly doesn't need it, but I suspect
seccompt.c expects to get it via this header.

  reply	other threads:[~2005-09-23  9:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-22 18:20 PATCH powerpc Merge asm-ppc*/seccomp.h Jon Loeliger
2005-09-22 18:31 ` Christoph Hellwig
2005-09-22 18:36   ` Jon Loeliger
2005-09-23  9:08     ` Christoph Hellwig [this message]
2005-09-23 12:54       ` Jon Loeliger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050923090809.GA31688@lst.de \
    --to=hch@lst.de \
    --cc=jdl@freescale.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=linuxppc64-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.