All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ftp.linux.org.uk>
To: Kyle Moffett <mrmacman_g4@mac.com>
Cc: Hirokazu Takata <takata@linux-m32r.org>,
	torvalds@osdl.org, linux-kernel@vger.kernel.org,
	sam@ravnborg.org
Subject: Re: [PATCH] m32r: set CHECKFLAGS properly
Date: Tue, 27 Sep 2005 18:55:26 +0100	[thread overview]
Message-ID: <20050927175526.GU7992@ftp.linux.org.uk> (raw)
In-Reply-To: <44F9E519-C94E-422B-9CA7-B24C2F76B78D@mac.com>

On Tue, Sep 27, 2005 at 01:31:25PM -0400, Kyle Moffett wrote:
> >    3) way, way, *WAY* too much spew.  gcc pre-defines shitloads of  
> >stuff and some of that stuff very definitely should not be there  
> >for sparse.
> 
> Why not?  Some of that stuff may get used in kernel headers, which  
> sparse should definitely have defined.  Besides, sparse is designed  
> to check C source code, which will be compiled with said GCC using  
> those preprocessing defines.  Why should it use a different set of  
> defines?

First of all, some of that stuff should not be used in kernel headers
and getting a warning about such uses is a Good Thing(tm).  What's
more, some are actively *wrong* for kernel - __STDC_HOSTED__, for one,
is simply a lie.  And no, sparse (or any other C compiler) is not
required to have the same pile as gcc does.

There's another reason why limited subset is good - it documents the
subset we are using.  And having to reach gcc source just to figure
out which architectures might have given symbol...  No, thanks.

  reply	other threads:[~2005-09-27 17:55 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-26  5:18 [PATCH] m32r: set CHECKFLAGS properly Al Viro
2005-09-27  6:13 ` Hirokazu Takata
2005-09-27  7:10   ` Al Viro
2005-09-27 15:13     ` Kyle Moffett
2005-09-27 16:34       ` Al Viro
2005-09-27 17:31         ` Kyle Moffett
2005-09-27 17:55           ` Al Viro [this message]
2005-09-27 18:37             ` Kyle Moffett
2005-09-27 23:06               ` Al Viro
2005-09-27 20:02     ` Sam Ravnborg
2005-09-28  1:44       ` Al Viro
2005-09-27  6:23 ` Hirokazu Takata
2005-09-27 15:00   ` Linus Torvalds
2005-09-28  0:18     ` Al Viro
2005-09-28 10:04       ` Hirokazu Takata
2005-09-29  1:56         ` Al Viro
  -- strict thread matches above, loose matches on Subject: below --
2005-09-26  5:19 Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050927175526.GU7992@ftp.linux.org.uk \
    --to=viro@ftp.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mrmacman_g4@mac.com \
    --cc=sam@ravnborg.org \
    --cc=takata@linux-m32r.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.