From: Jens Axboe <axboe@suse.de>
To: Nate Diller <nate@namesys.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] block cleanups: Fix iosched module refcount leak
Date: Wed, 28 Sep 2005 00:40:29 +0200 [thread overview]
Message-ID: <20050927224024.GJ2811@suse.de> (raw)
In-Reply-To: <4339C595.3080308@namesys.com>
On Tue, Sep 27 2005, Nate Diller wrote:
> If the requested I/O scheduler is already in place, elevator_switch simply
> leaves the queue alone, and returns. However, it forgets to call
> elevator_put, so
>
> 'echo [current_sched] > /sys/block/[dev]/queue/scheduler'
>
> will leak a reference, causing the current_sched module to be permanently
> pinned in memory.
>
> This patchset is against 2.6.14-rc2-mm1, but should apply to anything
> recent.
Thanks, looks good.
Signed-off-by: Jens Axboe <axboe@suse.de>
--
Jens Axboe
prev parent reply other threads:[~2005-09-27 22:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-27 22:20 [PATCH 1/3] block cleanups: Fix iosched module refcount leak Nate Diller
2005-09-27 22:40 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050927224024.GJ2811@suse.de \
--to=axboe@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nate@namesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.