Re: [uml-devel] Review needed for ubd fixes

[Jeff Dike <jdike@addtoit.com>]

On Wed, Sep 28, 2005 at 02:14:32PM +0200, Blaisorblade wrote:
> Very, very nice.
> 
> What about the early removal of the request from the queue, before being sure 
> we can complete it (sorry for not reading carefully everything below, I'm 
> going to have lunch and afterwards back to study).

I think that doesn't matter too much.  I have to get the sg information out
of it, and store that, plus the current position within the sg array if
we couldn't send it all to the host.  So, I don't refer to the request after
I get the sg information out of it, so I might as well remove it from the
queue.

> Reorder o_direct at the end - no time to read them yet, but guess that more 
> intrusive goes at the end. And I'm not sure whether merging o_direct so late 
> in 2.6.14 is nice (even if you've tested the full patch set, and without 
> o_direct the thing makes less sense).

Yeah, I wasn't planning on sending that for 2.6.14.  It was just part of that
set of patches.

> Let's hope for the better, but next time the debug should be done *before* 
> merging, ok? Even because, for instance, if (say) the patch was ready for 
> 2.6.14 and merged into 2.6.15, I could have released a test tree against 
> 2.6.14 (maybe I could do this now).

I thought I did.  AIO had been in my tree forever with no apparent problems.
I recently started running 24 hour/day stress tests on UML, and that turned
up some problems.  People turning on spinlock debugging turned up the sleeping
while atomic problem.  And me staring at the code as a result of that turned
up the possible deadlock.

> Please, send them to Andrew for -mm, and say "2.6.14 can't go without them, 
> but they might need further review".
> 
> And ask Jens Axboe if it can give a look to them (this time it's less 
> necessary, since there are less dirty tricks).

Yeah.  This still needs some work.  I need to deal with the bitmap array
properly.

				Jeff


-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel