From: Greg Edwards <edwardsg@sgi.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [Lhms-devel] RE: [PATCH 0/4] V4 ia64 SPARSEMEM
Date: Wed, 28 Sep 2005 22:05:19 +0000 [thread overview]
Message-ID: <20050928220518.GL14436@sgi.com> (raw)
In-Reply-To: <1127779977.10315.6.camel@localhost>
On Wed, Sep 28, 2005 at 11:42:44AM -0400, Bob Picco wrote:
| I had a problem booting sparsemem_defconfig without modules on my rx2600.
| After removing CONFIG_SGI_MBCS it booted fine.
|
| Badness in kref_get at lib/kref.c:32
|
| Call Trace:
| [<a000000100012080>] show_stack+0x80/0xa0
| spà00000003177c10 bspà00000003170fd0
| [<a0000001000120d0>] dump_stack+0x30/0x60
| spà00000003177de0 bspà00000003170fb8
| [<a0000001004edc20>] kref_get+0xa0/0xc0
| spà00000003177de0 bspà00000003170f98
| [<a0000001004ec570>] kobject_get+0x30/0x60
| spà00000003177de0 bspà00000003170f78
| [<a000000100646340>] get_bus+0x40/0xa0
| spà00000003177de0 bspà00000003170f58
| [<a000000100645ff0>] bus_add_driver+0x30/0x180
| spà00000003177de0 bspà00000003170f20
| [<a000000100647750>] driver_register+0x70/0xa0
| spà00000003177de0 bspà00000003170f00
| [<a000000100a5fc70>] cx_driver_register+0x70/0xa0
| spà00000003177de0 bspà00000003170ee0
| [<a000000100d8c3c0>] mbcs_init+0x80/0xc0
| spà00000003177de0 bspà00000003170ec0
| [<a000000100d5d170>] do_initcalls+0xb0/0x200
| spà00000003177de0 bspà00000003170e58
| [<a000000100d5d330>] do_basic_setup+0x70/0xa0
| spà00000003177de0 bspà00000003170e40
| [<a000000100009b70>] init+0x170/0x4e0
| spà00000003177de0 bspà00000003170e00
| [<a0000001000144f0>] kernel_thread_helper+0xd0/0x100
| spà00000003177e30 bspà00000003170dd0
| [<a0000001000094a0>] start_kernel_thread+0x20/0x40
| spà00000003177e30 bspà00000003170dd0
Looks like mbcs_init could use a platform check. Bruce, does this look
ok?
Signed-off-by: Greg Edwards <edwardsg@sgi.com>
drivers/char/mbcs.c | 3 +++
1 files changed, 3 insertions(+)
Index: git-linus/drivers/char/mbcs.c
=================================--- git-linus.orig/drivers/char/mbcs.c 2005-09-12 11:34:37.639213202 -0500
+++ git-linus/drivers/char/mbcs.c 2005-09-28 12:37:02.756895426 -0500
@@ -830,6 +830,9 @@ static int __init mbcs_init(void)
{
int rv;
+ if (!ia64_platform_is("sn2"))
+ return -ENODEV;
+
// Put driver into chrdevs[]. Get major number.
rv = register_chrdev(mbcs_major, DEVICE_NAME, &mbcs_ops);
if (rv < 0) {
next prev parent reply other threads:[~2005-09-28 22:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-27 0:12 [Lhms-devel] Re: [PATCH 0/4] V4 ia64 SPARSEMEM Dave Hansen
2005-09-27 14:07 ` Bob Picco
2005-09-27 14:25 ` Dave Hansen
2005-09-28 10:36 ` [Lhms-devel] " Bob Picco
2005-09-28 11:03 ` Robin Holt
2005-09-28 15:42 ` Bob Picco
2005-09-28 22:05 ` Greg Edwards [this message]
2005-09-28 22:10 ` Bruce Losure
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050928220518.GL14436@sgi.com \
--to=edwardsg@sgi.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.