From: Ralf Baechle <ralf@linux-mips.org>
To: Jan Pedersen <jan.pedersen@glaze.dk>
Cc: linux-mips@linux-mips.org
Subject: Re: [patch] cfi: prevent kernel panic with cfi flash
Date: Fri, 30 Sep 2005 01:20:17 +0100 [thread overview]
Message-ID: <20050930002017.GG3983@linux-mips.org> (raw)
In-Reply-To: <20050927192543.CAD8F376451@rocket.glaze.se>
On Tue, Sep 27, 2005 at 09:25:42PM +0200, Jan Pedersen wrote:
> When using the cfi (common flash interface) driver, every word written to
> the flash chips is followed by a operation complete poll. This poll is
> intended to have a timeout of 1 ms. However this timeout is calculated by
> HZ/1000, which happends to be 0 because HZ < 1000. The result of this is
> that there will be just one poll for operation complete. If this single poll
> fails, the kernel panics. This patch increases this timeout to HZ (1
> second). This is far more than needed, but is preferred over a panic. This
> fix is well tested and completely avoids the panic.
>
> Signed-off-by: Jan Pedersen <jp@jp-embedded.com>
Patch looks good to me - but this code isn't maintained by linux-mips.org,
so you may want to resend your patches here:
MEMORY TECHNOLOGY DEVICES
P: David Woodhouse
M: dwmw2@infradead.org
W: http://www.linux-mtd.infradead.org/
L: linux-mtd@lists.infradead.org
S: Maintained
Thanks anyway,
Ralf
next prev parent reply other threads:[~2005-09-30 10:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-27 19:25 [patch] cfi: prevent kernel panic with cfi flash Jan Pedersen
2005-09-27 19:25 ` Jan Pedersen
2005-09-30 0:20 ` Ralf Baechle [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-10-04 20:47 Jan Pedersen
2005-10-05 13:25 ` Jörn Engel
2005-10-06 20:19 ` Jan Pedersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050930002017.GG3983@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=jan.pedersen@glaze.dk \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.