All of lore.kernel.org
 help / color / mirror / Atom feed
From: Magnus Damm <magnus@valinux.co.jp>
From: Magnus Damm <magnus@valinux.co.jp>
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: Magnus Damm <magnus@valinux.co.jp>
Subject: [PATCH 01/07] i386: srat non acpi
Date: Fri, 30 Sep 2005 16:33:21 +0900 (JST)	[thread overview]
Message-ID: <20050930073237.10631.27035.sendpatchset@cherry.local> (raw)
In-Reply-To: <20050930073232.10631.63786.sendpatchset@cherry.local>

This patch adds code to check the return value of acpi_find_root_pointer().
Without this patch systems without ACPI support such as QEMU crashes when 
booting a NUMA kernel configured with CONFIG_ACPI_SRAT=y.

Signed-off-by: Magnus Damm <magnus@valinux.co.jp>
---

 srat.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletion(-)

--- from-0002/arch/i386/kernel/srat.c
+++ to-work/arch/i386/kernel/srat.c	2005-09-28 15:59:13.000000000 +0900
@@ -327,7 +327,12 @@ int __init get_memcfg_from_srat(void)
 	int tables = 0;
 	int i = 0;
 
-	acpi_find_root_pointer(ACPI_PHYSICAL_ADDRESSING, rsdp_address);
+	if (ACPI_FAILURE(acpi_find_root_pointer(ACPI_PHYSICAL_ADDRESSING, 
+						rsdp_address))) {
+		printk("%s: System description tables not found\n",
+		       __FUNCTION__);
+		goto out_err;
+	}
 
 	if (rsdp_address->pointer_type == ACPI_PHYSICAL_POINTER) {
 		printk("%s: assigning address to rsdp\n", __FUNCTION__);

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2005-09-30  7:33 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-30  7:33 [PATCH 00/07][RFC] i386: NUMA emulation Magnus Damm
2005-09-30  7:33 ` Magnus Damm, Magnus Damm [this message]
2005-09-30  7:33 ` [PATCH 02/07] i386: numa on non-smp Magnus Damm, Magnus Damm
2005-09-30  7:33 ` [PATCH 03/07] cpuset: smp or numa Magnus Damm, Magnus Damm
2005-09-30  7:33 ` [PATCH 04/07] i386: numa warning fix Magnus Damm, Isaku Yamahata
2005-09-30  7:33 ` [PATCH 05/07] i386: sparsemem on pc Magnus Damm, Magnus Damm
2005-09-30 15:25   ` Dave Hansen
2005-09-30 15:25     ` Dave Hansen
2005-10-01  0:32     ` Magnus Damm
2005-10-01  0:32       ` Magnus Damm
2005-09-30  7:33 ` [PATCH 06/07] i386: discontigmem " Magnus Damm, Magnus Damm
2005-09-30  7:33 ` [PATCH 07/07] i386: numa emulation " Magnus Damm, Isaku Yamahata
2005-09-30 18:55   ` Dave Hansen
2005-09-30 18:55     ` Dave Hansen
2005-10-03  9:59     ` Magnus Damm
2005-10-03  9:59       ` Magnus Damm
2005-10-03 16:16       ` Dave Hansen
2005-10-03 16:16         ` Dave Hansen
2005-10-04  5:06         ` Magnus Damm
2005-10-04  5:06           ` Magnus Damm
2005-10-04  7:52   ` Hirokazu Takahashi
2005-10-04  7:52     ` Hirokazu Takahashi
2005-10-04  9:49     ` Magnus Damm
2005-10-04  9:49       ` Magnus Damm
2005-09-30 15:23 ` [PATCH 00/07][RFC] i386: NUMA emulation Dave Hansen
2005-09-30 15:23   ` Dave Hansen
2005-10-03  2:08   ` Magnus Damm
2005-10-03  2:08     ` Magnus Damm
2005-10-03  7:34     ` David Lang
2005-10-03  7:34       ` David Lang
2005-10-03 10:02       ` Magnus Damm
2005-10-03 10:02         ` Magnus Damm
2005-10-03 13:33         ` David Lang
2005-10-03 13:33           ` David Lang
2005-10-03 14:59           ` Martin J. Bligh
2005-10-03 14:59             ` Martin J. Bligh
2005-10-03 15:03             ` David Lang
2005-10-03 15:03               ` David Lang
2005-10-03 15:08               ` Martin J. Bligh
2005-10-03 15:08                 ` Martin J. Bligh
2005-10-03 15:13                 ` David Lang
2005-10-03 15:13                   ` David Lang
2005-10-03 15:25                   ` Martin J. Bligh
2005-10-03 15:25                     ` Martin J. Bligh
2005-10-03 15:32                     ` David Lang
2005-10-03 15:32                       ` David Lang
2005-10-03 15:54                       ` Martin J. Bligh
2005-10-03 15:54                         ` Martin J. Bligh
2005-10-03 16:44                         ` David Lang
2005-10-03 16:44                           ` David Lang
2005-10-03 14:45       ` Martin J. Bligh
2005-10-03 14:45         ` Martin J. Bligh
2005-10-03 14:49         ` David Lang
2005-10-03 14:49           ` David Lang
2005-10-03  3:21   ` Paul Jackson
2005-10-03  3:21     ` Paul Jackson
2005-10-03  5:05     ` Magnus Damm
2005-10-03  5:05       ` Magnus Damm
2005-10-03  5:26       ` Hirokazu Takahashi
2005-10-03  5:26         ` Hirokazu Takahashi
2005-10-03  5:33       ` Paul Jackson
2005-10-03  5:33         ` Paul Jackson
2005-10-03  5:59         ` Magnus Damm
2005-10-03  5:59           ` Magnus Damm
2005-10-03  7:26           ` Paul Jackson
2005-10-03  7:26             ` Paul Jackson
2005-10-03  5:34       ` Paul Jackson
2005-10-03  5:34         ` Paul Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050930073237.10631.27035.sendpatchset@cherry.local \
    --to=magnus@valinux.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.