From: Ralf Baechle <ralf@linux-mips.org>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: linux-mips@linux-mips.org
Subject: Re: missing data cache flush for signal trampoline on fork
Date: Fri, 30 Sep 2005 16:10:52 +0100 [thread overview]
Message-ID: <20050930151052.GD3083@linux-mips.org> (raw)
In-Reply-To: <20050930.123241.72709288.nemoto@toshiba-tops.co.jp>
On Fri, Sep 30, 2005 at 12:32:41PM +0900, Atsushi Nemoto wrote:
> Date: Fri, 30 Sep 2005 12:32:41 +0900 (JST)
> To: linux-mips@linux-mips.org
> Cc: ralf@linux-mips.org
> Subject: Re: missing data cache flush for signal trampoline on fork
> From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> Content-Type: Text/Plain; charset=us-ascii
>
> >>>>> On Wed, 28 Sep 2005 20:57:58 +0900 (JST), Atsushi Nemoto <anemo@mba.ocn.ne.jp> said:
> anemo> Sorry, this would corrupt cpu_has_ic_fills_f_dc case. Revised.
>
> The patch was overkill. The indexed-flush is required only for
> d-cache. Revised.
Hmm... Your patch may be right for the time being but I think this should
the whole flushing biz should actually be handled via update_mmu_cache by
adding something along the lines of:
...
if (vma->flags & VM_EXEC)
do_flush_icache_page(addr);
...
What do you think?
Ralf
next prev parent reply other threads:[~2005-09-30 15:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-28 11:34 missing data cache flush for signal trampoline on fork Atsushi Nemoto
2005-09-28 11:57 ` Atsushi Nemoto
2005-09-30 3:32 ` Atsushi Nemoto
2005-09-30 15:10 ` Ralf Baechle [this message]
2005-09-28 15:09 ` Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050930151052.GD3083@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.