From: Greg Edwards <edwardsg@sgi.com>
To: linux-ia64@vger.kernel.org
Subject: [PATCH] set altix preferred console
Date: Fri, 30 Sep 2005 20:04:22 +0000 [thread overview]
Message-ID: <20050930200422.GD13855@sgi.com> (raw)
Set the preferred console on Altix, if no console=<console> was passed
on the boot line.
Bjorn, the hunk I removed in pcdp.c broke the vga console on Altix and
the virtual terminal if any console= was passed in. For example, if
you booted with console=ttySG0 (the L1 serial console), there would be
no login prompt on tty1 when you got to multiuser, even though a getty
was running. Is removing this ok?
Signed-off-by: Greg Edwards <edwardsg@sgi.com>
arch/ia64/sn/kernel/setup.c | 12 +++++++++---
drivers/firmware/pcdp.c | 3 ---
2 files changed, 9 insertions(+), 6 deletions(-)
Index: git-linus/arch/ia64/sn/kernel/setup.c
=================================--- git-linus.orig/arch/ia64/sn/kernel/setup.c 2005-09-12 11:34:36.342472611 -0500
+++ git-linus/arch/ia64/sn/kernel/setup.c 2005-09-30 14:49:50.941056190 -0500
@@ -281,15 +281,21 @@ void __init sn_setup(char **cmdline_p)
#if defined(CONFIG_VT) && defined(CONFIG_VGA_CONSOLE)
/*
* If there was a primary vga adapter identified through the
- * EFI PCDP table, make it the preferred console. Otherwise
+ * EFI PCDP table, and no console was specified on the boot
+ * line, make vga the preferred console.
+ *
+ * If no vga adapter was found, and no console was specified on
+ * the boot line, make the L1 console the preferred console and
* zero out conswitchp.
*/
if (vga_console_membase) {
- /* usable vga ... make tty0 the preferred default console */
- add_preferred_console("tty", 0, NULL);
+ if (!strstr(*cmdline_p, "console="))
+ add_preferred_console("tty", 0, NULL);
} else {
printk(KERN_DEBUG "SGI: Disabling VGA console\n");
+ if (!strstr(*cmdline_p, "console="))
+ add_preferred_console("ttySG", 0, NULL);
#ifdef CONFIG_DUMMY_CONSOLE
conswitchp = &dummy_con;
#else
Index: git-linus/drivers/firmware/pcdp.c
=================================--- git-linus.orig/drivers/firmware/pcdp.c 2005-08-24 16:06:59.911622221 -0500
+++ git-linus/drivers/firmware/pcdp.c 2005-09-30 14:49:50.998667555 -0500
@@ -99,9 +99,6 @@ efi_setup_pcdp_console(char *cmdline)
if (strstr(cmdline, "console=hcdp")) {
if (pcdp->rev < 3)
serial = 1;
- } else if (strstr(cmdline, "console=")) {
- printk(KERN_INFO "Explicit \"console=\"; ignoring PCDP\n");
- return -ENODEV;
}
if (pcdp->rev < 3 && efi_uart_console_only())
next reply other threads:[~2005-09-30 20:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-30 20:04 Greg Edwards [this message]
2005-09-30 21:20 ` [PATCH] set altix preferred console Bjorn Helgaas
2005-10-03 14:44 ` Greg Edwards
2005-10-04 15:04 ` Mark Maule
2005-10-04 19:07 ` Bjorn Helgaas
2005-10-04 20:46 ` Mark Maule
2005-10-11 20:00 ` Mark Maule
2005-10-11 21:19 ` Bjorn Helgaas
2005-10-11 21:31 ` Mark Maule
2005-10-11 21:57 ` Bjorn Helgaas
2005-10-12 18:55 ` Mark Maule
2005-10-13 13:10 ` Greg Edwards
2005-10-18 17:06 ` Luck, Tony
2005-10-18 18:33 ` Bjorn Helgaas
2005-10-18 18:39 ` Mark Maule
2005-11-11 17:52 ` Mark Maule
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050930200422.GD13855@sgi.com \
--to=edwardsg@sgi.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.